Download & Extend
User protect » Issues

Fix warning when no User protection defaults are enabled

Posted by dboulet on February 3, 2009 at 9:04pm
Project:User protect
Version:6.x-1.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I was getting this error at admin/user/userprotect/protection_defaults:

warning: Invalid argument supplied for foreach() in /includes/form.inc on line 1195.

The problem is that if no options on the form are checked, the returned default value is empty. The attached patch assures that the default value is always an array.

AttachmentSize
userprotect_defaultvalues.patch704 bytes
Login or register to post comments

Comments

#1

Posted by cedarm on July 11, 2009 at 12:44am

Wouldn't replacing the whole loop with $defaults = array_keys(array_filter($current_defaults)); be simpler?

#2

Posted by hunmonk on July 12, 2009 at 3:17pm
Title:Invalid default values in protection defaults form» Fix warning when no User protection defaults are enabled
Status:needs review» fixed

cedarm's fix in #1 is more elegant, so i've committed that to 5.x-1.x-dev and 6.x-1.x-dev.

thanks!

#3

Posted by System Message on July 26, 2009 at 3:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.