Tiny little patch adding hook_perm to this baby - making it possible to hide the "Tidy" link from roles that do not need it.

Comments

pwolanin’s picture

Status: Needs review » Needs work

whitespace problem - looks like a tab in hook_perm

Add doxygen comments indicating which hooks are being implemented.

improve form_id check

horncologne’s picture

Status: Needs work » Needs review
StatusFileSize
new1.33 KB

Rerolled!

- Added doxygen comments
- Removed errant tab char
- Implemented suggested form_id check

Thanks, Peter!

paul.lovvik’s picture

StatusFileSize
new1.35 KB

The code looks good, but the comments aren't exactly the right format. They should look something like this:

/**
 * Implementation of hook_perm().
 */

Of course the asterisks should align vertically. Otherwise I tested the code and it works fine. Attached is a patch that corrects the comment format.

pwolanin’s picture

patch looks fine visually

paul.lovvik’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.