Download & Extend

Add role-based permission to Tidy filter module

Project:Export DocBook
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Tiny little patch adding hook_perm to this baby - making it possible to hide the "Tidy" link from roles that do not need it.

AttachmentSize
tidy_perm.patch1.06 KB

Comments

#1

Status:needs review» needs work

whitespace problem - looks like a tab in hook_perm

Add doxygen comments indicating which hooks are being implemented.

improve form_id check

#2

Status:needs work» needs review

Rerolled!

- Added doxygen comments
- Removed errant tab char
- Implemented suggested form_id check

Thanks, Peter!

AttachmentSize
tidy_perm_2.patch 1.33 KB

#3

The code looks good, but the comments aren't exactly the right format. They should look something like this:

/**
* Implementation of hook_perm().
*/

Of course the asterisks should align vertically. Otherwise I tested the code and it works fine. Attached is a patch that corrects the comment format.

AttachmentSize
tidy_perm_3.patch 1.35 KB

#4

patch looks fine visually

#5

Status:needs review» fixed

Committed.

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.