Add role-based permission to Tidy filter module
horncologne - February 4, 2009 - 10:37
| Project: | Export DocBook |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
Tiny little patch adding hook_perm to this baby - making it possible to hide the "Tidy" link from roles that do not need it.
| Attachment | Size |
|---|---|
| tidy_perm.patch | 1.06 KB |
#1
whitespace problem - looks like a tab in hook_perm
Add doxygen comments indicating which hooks are being implemented.
improve form_id check
#2
Rerolled!
- Added doxygen comments
- Removed errant tab char
- Implemented suggested form_id check
Thanks, Peter!
#3
The code looks good, but the comments aren't exactly the right format. They should look something like this:
/*** Implementation of hook_perm().
*/
Of course the asterisks should align vertically. Otherwise I tested the code and it works fine. Attached is a patch that corrects the comment format.
#4
patch looks fine visually
#5
Committed.
#6
Automatically closed -- issue fixed for 2 weeks with no activity.