Problem after upgading from 6.x-1.0-rc3

pivica - February 4, 2009 - 21:00
Project:Workflow
Version:6.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

After upgrading from 6.x-1.0-rc3 to 6.x-1.1 workflow form on node edit form is not working correctly. First for users that have permission to change workflow state part of workflow fieldset on node edit form is missing. When doing node form submit I am getting next error:

warning: array_key_exists() [function.array-key-exists]: The first argument should be either a string or an integer in /home/ivicap/moje/bin/xampp/htdocs/natropolis.montenasoft.com/sites/all/modules/workflow/workflow.module on line 270.

After some investigation I found that $name value is not initialized for workflow_node_form call on line 470 in workflow.module. Checking diff of varius version between rc3 and 1.1 reveals that line 431 in revision 1.74 is deleted in 1.75 (diff link)

$name = check_plain(workflow_get_name($wid));

After returning erased line in 6.x-1.1 everything is working correctly.

Am I having some upgrade problem here or is this a bug because $name is not initialized?

#1

jvandyk - February 4, 2009 - 21:07
Status:active» duplicate

http://drupal.org/node/364608

#2

Parkes Design - September 9, 2009 - 02:59

pivica many thanks for your solution... this was driving me nuts. I wonder why this is still in patch form and not rolled out into the release version?

#3

pivica - November 11, 2009 - 13:18
Status:duplicate» fixed

Just checked latest workflow release (Workflow 6.x-1.3) and $name is now initialized with empty string. With this change it seems everything is working ok. Marking this fixed.

#4

System Message - November 25, 2009 - 13:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.