It looks like a new admin page has been added in for listing books on the site. If there aren't any books, the user is not given any message about what might appear beneath the table header that's floating on the page. : )

I checked other places, like comments and vocabulary term lists. There the pattern seems to be "No ____ available." This patch adds that for books, does some minor code cleanup, and adds some (maybe unnecessary?) comments.

CommentFileSizeAuthor
no_books_available.patch1.21 KBrszrama

Comments

rszrama’s picture

Assigned: Unassigned » rszrama

(Self-assign if that's acceptable.)

rszrama’s picture

Issue tags: +Quick fix, +ui, +code cleanup
webchick’s picture

Status: Needs review » Needs work
Issue tags: -Quick fix

Actually, this should be using the new tableselect element from #42962: Disable personal themes?. Docs aren't available yet (I have already given the patch author a stern talking to :P) but it's fairly easy.

rszrama’s picture

(Note to self: awaiting feedback from this comment on a related issue, since this isn't actually a form and doesn't have any bulk operations for books listed.)

webchick’s picture

Issue tags: +Quick fix

Yes, sorry. I'm smoking much less crack now!

Committed to HEAD. :) Thanks!

webchick’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -ui, -code cleanup

Automatically closed -- issue fixed for 2 weeks with no activity.