The review code that will run on the test client needs to be abstracted to allow for easy extensibility. I'm thinking of OO would be best in this situation to allow easy overriding of specific review steps.

This will make it easy to create custom handlers for each of the test types and environments.

CommentFileSizeAuthor
#10 pgsql-pifr.patch5.99 KBjosh waihi
#10 INSTALL.pgsql_.txt775 bytesjosh waihi
#10 pgsql.inc_.txt1003 bytesjosh waihi
#8 pifr-pgsql.patch4.22 KBjosh waihi
#6 pifr_abstract_review.patch75.69 KBboombatower

Comments

boombatower’s picture

boombatower commented

Once complete, #337795: Test patches on multiple environments.

josh waihi’s picture

josh waihi commented

you write the base class, I'll write the postgres extension ;)

boombatower’s picture

boombatower commented

@Josh Waihi: that sounds great. I'll make a comment when it is ready for you.

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower

Started.

boombatower’s picture

boombatower commented

All the way through applying patch.

NOTE: this code can handle reviewing modules in addition to core.

boombatower’s picture

boombatower commented
StatusFileSize
new pifr_abstract_review.patch75.69 KB

Mid-way patch...have some unexpected things coming up so I'm putting it here so I can download where ever I end up.

boombatower’s picture

boombatower commented

There is an initial set of code for db stuff ready. I will be adding an additional function once the core bug #377564: SimpleTest: run-tests.sh ignores 'simpletest_clear_results' is fixed.

@Josh Waihi: if you want to work on an initial postgres backend that would be fine...only make a db backend that implements the interface.

The installer itself should always select the default database type, but to be sure I can add some code to select the current db type...that is not part of your backend...I'll add that shortly.

josh waihi’s picture

josh waihi commented
StatusFileSize
new pifr-pgsql.patch4.22 KB

my postgres progress thus far plus a few more other things like admin config menu

josh waihi’s picture

josh waihi commented

*sigh* in a stupid rush, that patch doesn't really help anybody

josh waihi’s picture

josh waihi commented
StatusFileSize
new pgsql.inc_.txt1003 bytes
new INSTALL.pgsql_.txt775 bytes
new pgsql-pifr.patch5.99 KB

OK, I think this will work. Can't say for sure since PostgreSQL and D7 HEAD have issues. couldn't figure out how to include new files in diff so I'm attaching them. the diff shows where to put them. pgsql.inc was renamed for security reasons

boombatower’s picture

boombatower commented

Committed intial database backend after modification and addition of getAssertions() method.

I assume this is valid in postgres (just want to be sure)

  public function getAssertions() {
    if (db_set_active('pifr_checkout')) {
      $result = db_query("SELECT *
                          FROM {simpletest}
                          WHERE status != '%s'", 'pass');
      db_set_active();
      return TRUE;
    }
    return FALSE;
  }
boombatower’s picture

boombatower commented
Status: Active » Fixed

Completed rest of necessary components and a bit of cleanup.

Doesn't support the setup of SimpleTest 6.x-2.x for testing of D6, but that is not priority. Everything else is nicely abstracted. Will include in 6.1 (once PIFR 2.x is stable).

Opened #379114: Update INSTALL.txt to keep track of INSTALL.txt changes which this issue created.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.