fieldgroup not followed

radj - February 5, 2009 - 12:32
Project:Comment CCK
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:alter, CCK, comment, fieldgroup
Description

Fields are not organized by fieldgroup. They just appear like normal fields with no grouping.
I have a lot of fields that can be altered through comments but in the actual node, they are optional and collapsed in a fieldgroup hidden from plain view.
It would be awesome if the fieldgroup worked. Or am I not doing it right?

#1

matt2000 - March 30, 2009 - 23:49
Component:User interface» Code
Status:active» needs review

This is a bug in the D6 upgrade. Here's a patch to fix. It simply adds the last line shown below:

      // This will hold the form with only the fields we need
      $final_form = array();
      $final_form['#node'] = $node;

in function comment_cck_form_alter().

The new line comes after line 32 in my copy.

AttachmentSize
comment_cck_fieldgroup.patch 698 bytes

#2

joshuajabbour - March 31, 2009 - 01:06
Status:needs review» reviewed & tested by the community

This works as described. Thanks!

#3

joshuajabbour - March 31, 2009 - 21:58
Status:reviewed & tested by the community» needs work

Actually, this doesn't seem to work. It seems to cause any changed values to not be recorded if the field is in a fieldgroup.

#4

joshuajabbour - April 1, 2009 - 01:29

I've written a new, unified patch that fixes this issue along with a few others. It's listed under #420092: Bring comment_cck up-to-date, combine patches and can (should) be applied in place of the patch above.

#5

opensanta - May 8, 2009 - 20:09
Status:needs work» fixed

Committed. Thanks!

#6

opensanta - May 9, 2009 - 08:05
Status:fixed» needs work

Actually, fieldgroups don't seem to have the configuration available.

#7

opensanta - May 9, 2009 - 23:00
Status:needs work» fixed

Actually, this is fixed. I expected to be able to have an #458488: Option to enable commment cck per fieldgroup, so I opened that as a separate issue.

#8

System Message - May 23, 2009 - 23:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.