OGUR options don't show up in group node
michtoen - February 6, 2009 - 00:25
| Project: | OG User Roles |
| Version: | 6.x-1.4 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
I had a handful OG groups created on a somewhat fresh installation (OGUR never installed).
When i install OGUR all options are there, the membership assignment stuff also appears in the group
membership area but when you hit edit on the group node itself, no option there shows up - for
example the group logo and other related stuff. 1.3 only, 1.2 works fine.
#1
Even as user #1?
#2
yes, that was my first guess too. They don't appeared
#3
I've updated 3 sites with ogur 6.x-1.3 and don't see this. Is ogur otherwise working as expected?
#4
I don't tested it out... I also checked my old install, where 1.2 worked since some time - if i upgrade to 1.3 the
options in the OG content types vanished.
It can perhaps a site effect of my installed modules.
I have this installed:
Drupal 6.9
Block Cache Alter 6.x-1.1
Cache browser 6.x-1.3
Email Change Confirmation 6.x-1.2
Format Number API 6.x-1.3
Image 6.x-1.0-alpha4
ImageAPI 6.x-1.2
ImageCache 6.x-2.0-beta5
Messaging 6.x-1.1
Notifications 6.x-1.1
Organic groups 6.x-1.1
Organic groups permissions 6.x-1.x-dev (2009-Jan-12)
Pathauto 6.x-2.x-dev (2008-Dec-14)
Path Cache 6.x-1.2
Privatemsg 6.x-1.x-dev (2009-Jan-28)
Quota by role 6.x-7.x-dev (2008-Apr-02)
Signup 6.x-1.0-rc3
Token 6.x-1.x-dev (2008-Dec-11)
Views 6.x-2.2
Web File Manager 6.x-2.10-rc3
Well, nothing real special...
I have no idea, but the effect appears on a 6.8 with this and moree modules on my windows localhost and
on a full featured debian server with this setup.
#5
I suggest you test it.
Could you explain this in more detail?
In administer->organic groups->ogur settings, the first fieldset should be Your Group Content Type role options which contains the list of "Assignable roles". Do you see your Group Content Type here and/or Assignable roles?
#6
By the way, here is the code which controls placing the ogur options on the group node page. This code has not changed since 6.x-1.2:
<?php
// If this is a group node edit (use og_last to determine if this is a group node)
if (arg(0) == 'node' && ($_SESSION['og_last']->nid == arg(1)) && arg(2) == 'edit' ) {
$gid = arg(1);
// First, we need to get a list of all og-enabled node types
$group_types = og_get_types('group');
foreach ($group_types as $type) {
// Get list of assignable group roles for this group type
$role_ids = variable_get("og_user_roles_roles_{$type}", array());
$all_roles = user_roles();
foreach ($role_ids as $rid => $checked) {
if ($checked != 0) {
$roles[$rid] = $all_roles[$rid];
}
}
// If the form loaded is this type then we can move on
if ($type != '' && $form_id == $type . "_node_form") {
?>
Are you saying that all the modules on your site are the exact same when you install 6.x-1.3 as they were when you were running 6.x-1.2?
#7
right.
Sorry, i am building just my site, i have not much time for testing.
I did some speed test - the problem of OGUR and other modules
that they disabled the block cache is a big problem for us, we
have alot registered users in short times (>100k).
We can go the easy way: i contact you over this website and you can
login to my current site as admin and play around a bit, i have not
transfered the user DB and you can see the effect.
#8
I'm not sure how you figure I'm supposed to have time to work through your problem while you don't have time to test on your end.
See above.
This issue appears to be related: http://drupal.org/node/369847
Now, I'm confused because you said 6.x-1.2 works but 6.x-1.3 doesn't. If I understand what you're saying in the related issue above, NO ogur 6.x release should be working for you at all.
Unless you're mixing issues, I still don't get what the problem is since ogur 6.x-1.2 and 6.x-1.3 are almost identical.
#9
Not sure you understand: If you creating a OG group... then, you go to edit that group.
You see there the options from OGUR. Like, you can upload a logo to that group.
We talk about the node, not the about the admin area.
With 1.3, the OGUR options are not in the edit part. With 1.2, they are.
I just reported it, perhaps its me.
Sorry when it sounds rude, but i have not he time to test it from ground.
Let the topic open, if its a valid problem other will report too.
#10
I understand.
Same problem with 6.x-1.x-dev?
#11
I am having the same problem, with 6.x.-1.3
I tried replacing this line in the module:
if (arg(0) == 'node' && ($_SESSION['og_last']->nid == arg(1)) && arg(2) == 'edit' ) {...}with this one
if (true){...}and the missing items reappeared.
I then printed out the variable $_SESSION['og_last'], and it is an integer (the node ID). There is no 'nid' field.
So I then tried replacing the original line with the following, and the missing lines reappear:
if (arg(0) == 'node' && ($_SESSION['og_last'] == arg(1)) && arg(2) == 'edit' ) {...}Is this the correct fix?
Would you advise me to replace all the occurrences of
$_SESSION['og_last']->nidwith
$_SESSION['og_last']Thanks,
Mindy
#12
Apparently, OG has changed the format of og_last in 6.x. It is now an integer as opposed to an object. Committed this change to cvs. Install the latest dev (in about 12 hours) and please report back as to whether this resolves issue. If it does, then a new ogur version will be released for use with og 6.x-1.1.
#13
Please download and test dev release.
#14
Hi,
I tested the 6.x-1.x dev version, but the problem is still there. I will try again tomorrow. Thanks for your very quick response!
- Mindy
#15
If the dev version you installed does not have this line:
then the version you downloaded is not the version I just uploaded. This line was changed to exactly the line you said would work. It apparently had not yet been packaged when you did your download.
The changes are, in fact, here:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/og_user_rol...
#16
Yes, this fixed the problem. Thank you very much!
And thank you for a really great module.
- Mindy
#17
Fixed in 6.x-1.x-dev.
#18
Committed to 6.x-1.4 release.
#19
thanks!
- Mindy
#20
Automatically closed -- issue fixed for 2 weeks with no activity.
#21
Hi,
This is a very powerful module! I just have one issue: I'm working with a fresh install of OGUR 6.x-1.4 and OG 6.x-1.1. I set the Page content type as a group node and configured my OGUR settings for this type. When I visit node/add/page I do not see any of the OGUR options. Only once I create the node and edit it do I start to see the OGUR options. Is this the intended behavior?
#22
Yes, this is the intended behaviour. The options don't appear until the node is saved.