First i would like to say this module seems just awsome, if we could rate modules id give thisone a 10+ :)
Truly useful for community sites!
I tested the latest dev version with genesis based them and the feedback form is always expanded covering half the screen. Does anyone have an idea of a solution!
If not then would it be possible to ad an option to display a link to the feedback form instead of the expandable box?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | feedback-DRUPAL-6--2.block-markup.patch | 4.29 KB | sun |
| #5 | feedback-text-area.png | 3.15 KB | ludditetechnologies |
| #1 | Picture 1.png | 33.27 KB | devinhedge |
Comments
Comment #1
devinhedge commentedConfirmed that this is an issue.
Comment #2
sunSorry, there are too many themes in the wild. Feedback supports all stock themes in Drupal core. Any other theme, custom or not, might need further tweaks to work as expected. I have lost too much time with similar issues regarding Zen* themes already.
Comment #3
Jeff Burnz commentedFeedback js relies on the .content class being added to the div wrapper around the $block->content, so supporting this is just a matter of copy/pasting the default block.tpl.php template that comes with your theme and adding content class to that wrapper.
Call the new template suggestion "block-feedback.tpl.php", then add the "content" class as shown below, upload and clear the cache in performance settings.
Genesis and a few other themes use the class "block-content" rather than just content, so this will be a fix for a number of themes.
@sun, dont be shy to shift issues over to my queue for theme specific questions, its no problem;)
Comment #4
sunI have a patch for this somewhere laying around...
Comment #5
ludditetechnologies commentedUsing a custom theme and my feedback is displayed as a standard text area field at the bottom of the page, somehow it isnt finding the css or javascript properly I think (with my limited knowledge).
As suggested I created a new block-feedback.tpl.php with the
<div class="block-content content"><?php print $block->content ?></div>code added, but assume I need to call this new file into action but I dont know how.
I also modified the block.tpl.php with
<div class="block-content content"><?php print $block->content ?></div>but that didnt fix it for me.
Did anyone have any suggestions please? It is a great module for less experienced site users to be easily able to feedback about a page and I would love to use it.
Cheers.
Comment #6
Jeff Burnz commentedClear cache data on the performance settings page, then Drupal will pick up the new template.
Comment #7
ludditetechnologies commentedYes I did that and could see my menu alignment altered slightly so I assumed it had taken effect. I have caching mode disabled while I am developing the site.
Thanks for the suggestion, did you have any more for me to try please?
Comment #8
mathieso commentedJust to clarify, don't add a
contentclass to the outerdivin the fileblock-feedback.tpl.php. Instead, wrap$block->contentin an entirely newdiv.My
block-feedback.tpl.phpfile started out looking something like this:Ended up like this:
The additions are marked
<!-- New line -->.Hope this helps.
Kieran Mathieson
http://coredogs.com
Comment #9
rares commentedworks for me.
Comment #10
sunPlease test attached patch.
Comment #11
sunThanks for reporting, reviewing, and testing! Committed to all branches.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.