Feedback box always expanded if .content class is not on the $block->content wrapper div
volf - February 6, 2009 - 15:31
| Project: | Feedback 2.0 |
| Version: | 6.x-2.0 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
First i would like to say this module seems just awsome, if we could rate modules id give thisone a 10+ :)
Truly useful for community sites!
I tested the latest dev version with genesis based them and the feedback form is always expanded covering half the screen. Does anyone have an idea of a solution!
If not then would it be possible to ad an option to display a link to the feedback form instead of the expandable box?
#1
Confirmed that this is an issue.
#2
Sorry, there are too many themes in the wild. Feedback supports all stock themes in Drupal core. Any other theme, custom or not, might need further tweaks to work as expected. I have lost too much time with similar issues regarding Zen* themes already.
#3
Feedback js relies on the .content class being added to the div wrapper around the $block->content, so supporting this is just a matter of copy/pasting the default block.tpl.php template that comes with your theme and adding content class to that wrapper.
Call the new template suggestion "block-feedback.tpl.php", then add the "content" class as shown below, upload and clear the cache in performance settings.
<div class="block-content content"><?php print $block->content ?></div>Genesis and a few other themes use the class "block-content" rather than just content, so this will be a fix for a number of themes.
@sun, dont be shy to shift issues over to my queue for theme specific questions, its no problem;)
#4
I have a patch for this somewhere laying around...
#5
Using a custom theme and my feedback is displayed as a standard text area field at the bottom of the page, somehow it isnt finding the css or javascript properly I think (with my limited knowledge).
As suggested I created a new block-feedback.tpl.php with the
<div class="block-content content"><?php print $block->content ?></div>code added, but assume I need to call this new file into action but I dont know how.
I also modified the block.tpl.php with
<div class="block-content content"><?php print $block->content ?></div>but that didnt fix it for me.
Did anyone have any suggestions please? It is a great module for less experienced site users to be easily able to feedback about a page and I would love to use it.
Cheers.
#6
Clear cache data on the performance settings page, then Drupal will pick up the new template.
#7
Yes I did that and could see my menu alignment altered slightly so I assumed it had taken effect. I have caching mode disabled while I am developing the site.
Thanks for the suggestion, did you have any more for me to try please?
#8
Just to clarify, don't add a
contentclass to the outerdivin the fileblock-feedback.tpl.php. Instead, wrap$block->contentin an entirely newdiv.My
block-feedback.tpl.phpfile started out looking something like this:<div id="block-<?php print $block->module .'-'. $block->delta; ?>" class="widget block block-<?php print $block->module ?>"><?php if ($block->subject): ?>
<h3><?php print $block->subject ?></h3>
<?php endif;?>
<?php print $block->content ?>
<div class="widgetbottom"></div>
</div><!-- /widget -->
Ended up like this:
<div id="block-<?php print $block->module .'-'. $block->delta; ?>" class="widget block block-<?php print $block->module ?>"><?php if ($block->subject): ?>
<h3><?php print $block->subject ?></h3>
<?php endif;?>
<div class="content"> <!-- New line -->
<?php print $block->content ?>
</div> <!-- New line -->
<div class="widgetbottom"></div>
</div><!-- /widget -->
The additions are marked
<!-- New line -->.Hope this helps.
Kieran Mathieson
http://coredogs.com
#9
works for me.
#10
Please test attached patch.