Bitcache deletes files from system (was: Eiether Views 2 or File Framework just deleted every file in my public folder)

I doubt that FileFramework could have deleted the files on your system. FileFramework does not work with the files directly, but via the Bitcache module. The Fileframework could not delete files it is not aware of.

ditto here too.

this is my favorite bug of all time.

just use the devel module to reinstall the file module and watch what happens.

amazing!

file framework calls bitcache_delete_repository('file'). this calls File::destroy($options), where $options is second argument of the delete_repository. Therefore there are NO options and there is no path. No File::$path variable, therefore rmdir_rf is called and it deletes "/*".

voila...

When the files were deleted, were you using a new installation of the bitcache/fileframework, or updated earlier versions?

To avoid this problem please upgrade to the dev version of the bitcache. This issue is already solved and should not occur in the dev version. Nevertheless, I have added a safeguard condition before calling Bitcache_FileRepository::rmdir_rf() to check if the path is not empty.

Alternatively, if you're using a bitcache beta2 version and want to uninstall the bitcache and fileframework, please, uninstall the fileframework first and only then proceed to uninstalling bitcache.

This issue occurs if the bitcache and fileframework are unistalled at the same time. The drupal uninstalls the disabled modules alphabetically, which means that bitcache is uninstalled first and bitcache_repositories table is removed before a fileframework unistall takes place. Fileframework, on the other hand, on uninstall tries to load it's repository info and fails since it is already deleted in the bitcache uninstall. Bitcache beta2 version defaults to the "file" adapter if no repository info is available which results in the instantiation of the class Bitcache_FileRepository and invocation of the method rmdir_rf() without a $path defined. Dev version of the bitcache does not defaults to the "file" repository if no repository data is available.

@Arto, should you consider a cut of a new release to prevent people who are not aware of the issue from losing the files?

This just happened to me and I could nearly cry, damn u!!

There is a bug in bitcache - doesn't check to see if 'file' is null. PHP just happy to process.

I just walloped a whole system with this - installed file framework for a couple of hours, it didn't install properly (as per http://drupal.org/node/425884).

Uninstall, uninstalled the entire machine.

It is basically a bug in bitcache.

file.install - you call

bitcache_delete_repository('file');

The reference to 'file' must have been null and then follows through in bitcache to:

foreach (glob($dirname . '/*', GLOB_NOSORT) as $file) {

Youch. I am going to raise a bug in bitcache as well. Can't be too paranoid with this stuff.

See file.inc in bitcache

function destroy(array $options = array()) {
if (!isset($options['contents']) || $options['contents'] !== FALSE) {
return $this->rmdir_rf($this->path); // delete the contents of the repository directory
}

/**
* Recursive version of rmdir(); use with extreme caution.
*
* @param $dirname
* the top-level directory that will be recursively removed
* @param $callback
* optional predicate function for determining if a file should be removed
*/
protected function rmdir_rf($dirname, $callback = NULL) {
$empty = TRUE; // begin with an optimistic mindset

foreach (glob($dirname . '/*', GLOB_NOSORT) as $file) {
if (is_dir($file)) {
if (!$this->rmdir_rf($file, $callback)) {
$empty = FALSE;
}
}
else if (is_file($file)) {
if (function_exists($callback) && !$callback($file)) {
$empty = FALSE;
continue;
}
@unlink($file);
}
else {
$empty = FALSE; // it's probably a symbolic link
}
}

// The reason for this elaborate safeguard is that Drupal will log even
// warnings that should have been suppressed with the @ operator.
// Otherwise, we'd just rely on the FALSE return value from rmdir().
return ($empty && @rmdir($dirname));
}
}