This patch is somewhat a proof-of-concept but something we might want to consider to improve the usability of the node form. It uses the new FAPI property introduced in #370537: Allow suppress of form errors (hack to make "more" buttons work properly) to skip the #required and #element_validate properties when previewing nodes.
To try out:
- Create a new node (any type) in Drupal, try filling out the body of the form but skip the Title field (or other required fields).
- Click "Preview".
It's important to note that "form level" validation still occurs. For example, you can't preview a new Poll if you don't add any choices.
| Comment | File | Size | Author |
|---|---|---|---|
| node_preview_validation.patch | 908 bytes | quicksketch |
Comments
Comment #1
drewish commentedsubscribing
Comment #2
drewish commentedsubscribing
Comment #3
quicksketchDrewish pointed out to me that this should definitely occur when trying to delete nodes that don't have required fields set. Perhaps that should be a separate patch, since it won't have any controversy.
Comment #4
coltraneThere's a 6 issue about skipping validation when deleting #280465: #required (and #element_validate too?) not skippable that could be marked a dupe. @quicksketch in #3 just to clarify are you saying that when deleting nodes validation should definitely be skipped?
Comment #5
quicksketchThat's right, since the delete button just redirects to a separate delete form anyway, we don't need to make sure that the user entered a title.
Comment #6
cburschka+1. It is extremely annoying particularly on the d.o wiki pages, where you have to enter a revision message before being allowed to preview. (Not only that, but the revision message is lost from the form on preview - but that is a different bug.)
I see no obvious problems that still need to be fixed, though maybe it could do the same for deletion already in this patch...
Comment #7
quicksketchThere are all kinds of security problems with this current approach, see #370537: Allow suppress of form errors (hack to make "more" buttons work properly) for progress being made there. This patch doesn't work any more with the latest versions of the patch, since they close up security problems that make it so that this task is much more difficult.
Comment #8
cburschkaSo postpone it, I guess?
Comment #10
Anonymous (not verified) commentedDo we still want to try to support this?
Comment #11
quicksketchComment #12
xjm(Merging "node system" and "node.module" components for 8.x; disregard.)
Comment #24
smustgrave commentedClosing out as outdated as comment #10 has gone unanswered for 10 years. If still an issue please reopen.