I just started using this module and first i must say big thanks for creating it.
I saw that it does not have tests (simpletest) for it.
I think I can put some time and try to create some, but unfortunately i need some experience with this module. Can anyone give me some directions (like what should be tested) ?

CommentFileSizeAuthor
#4 nodehierarchy.test4.11 KBandreiashu
#2 nodehierarchy.test3 KBandreiashu

Comments

ronan’s picture

ronan commented

I'd appreciate any help you can give. I'm not sure what the best strategy for testing should be as I'm horribly bad at writing test myself. My instinct is to test every single function which leads to hours of coding and a very low percentage of test coverage.

Probably the major operations should be tested: setting parents, reordering children, creating menus, tokens.

Let me know if there's anything I can do to help
R

andreiashu’s picture

andreiashu commented
StatusFileSize
new nodehierarchy.test3 KB

I've made a stub. I'll put it here so maybe other can contribute. I'll add stuff to it when i have time.
You must put this .test file under directory tests in NH directory.
Also NH must implement hook_simpletest like this (sorry, didn't ahve time to make a patch):

/**
 * Implementation of hook_simpletest().
 */
function nodehierarchy_simpletest() {
  $dir = drupal_get_path('module', 'nodehierarchy') .'/tests';
  $tests = file_scan_directory($dir, '\.test$');
  return array_keys($tests);
}

Beware, i'm no expert in simpletest either :)

andreiashu’s picture

andreiashu commented
Status: Active » Needs work
andreiashu’s picture

andreiashu commented
StatusFileSize
new nodehierarchy.test4.11 KB

Do we need to check for permissions too ? (siteoutline, add parent nodes, etc)

ronan’s picture

ronan commented
Status: Needs work » Active

Awesome! I've commited the stub. Thanks for getting the ball rolling.

I'm setting this back to active so we can work on fleshing out the tests.

Thanks again
Ronan

andreiashu’s picture

andreiashu commented

Nice that you committed them. I will take a look over them again when i'll get some time.

Thanks
andreiashu

markhalliwell’s picture

markhalliwell
Primary language English
commented
Component: Code » Drupal/PHP Code

Copy & Pasted: This issue pertains to the 6.x-1.x branch which is now legacy and is over two years old. If this issue is not applicable anymore, please consider closing it. Otherwise, please update this issue appropriately. Will be closed in two weeks if no response.

jbylsma’s picture

jbylsma commented
Status: Active » Fixed

Cleaning up the queue. As the initial tests were committed, I'm going to mark this as fixed.

Status: Fixed » Closed (fixed)
Issue tags: -simpletests

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +simpletests

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.