Incorrect logic in views_many_to_one_helper::ensure_my_table()

Huh? That's what the code is currently doing (that is, using just the table plus a count as the identifier). The patch I uploaded doesn't change the way that the alias is created, other than it doesn't start counting from 0 with each table $field, as the current code does, but with each actual table that's used.

It's been a week with no follow up on this issue. I don't know if that means that you've been busy with other things or if you still don't see what the problem is here. On the chance that it's the later, I thought I'd be a little more explicit as to the problem.

For both examples below let's use the following situation where views_many_to_one_helper::ensure_my_table() is called twice. The first time its called,

$this->handler->table = term_node
$this->handler->field = project_type_tid

and the second time

$this->handler->table = term_node
$this->handler->field = tid

These are real values that come from a custom relationship (first one) and the Term:tid filter that ships with views (second one).

The current relevant code is this:

          if (!isset($this->handler->view->many_to_one_aliases[$field][$value])) {
            if (!isset($this->handler->view->many_to_one_count[$field])) {
              $this->handler->view->many_to_one_count[$field] = 0;
            }
            $this->handler->view->many_to_one_aliases[$field][$value] = $this->handler->table . '_value_' . ($this->handler->view->many_to_one_count[$field]++);
          }
          $alias = $this->handler->table_aliases[$value] = $this->add_table($join, $this->handler->view->many_to_one_aliases[$field][$value]);
// .....

So the first time this code is called, $this->handler->view->many_to_one_count[$field] will not be set, the counter will be set to 0, and therefore $this->handler->view->many_to_one_aliases[$field][$value] will be set to term_node_value_0. That's all fine. But then the second time this is called, $this->handler->view->many_to_one_count[$field] will also be unset (because this time $field is 'tid' where before it was 'project_type_tid'. That means that a new counter will be used, and it will be reset to 0, and therefore the second time ensure_my_table() is called $this->handler->view->many_to_one_aliases[$field][$value] will again be set to term_node_value_0.

The reason is that only $this->handler->table is concatenated into a string to produce what will be the alias, and in this example both times this function is called this will be equal to "term_node".

Hopefully this clears up what the problem is.