Rename clear-block CSS class to clearfix [#371231]

Drupal uses a CSS class called "clear-block" that allows a container DIV to always enclose any floated children elements.

The CSS community calls this class "clearfix". I'm not sure why Drupal decided to change that. A quick Google search shows that there are over 167,000 references to clearfix css, but only about 1000 references to clear-block.

So, I think we should change "clear-block" to "clearfix".

The CSS community already calls knows this technique as a "clearfix".
Drupal already has too many "blocks". "clear-block" adds to the namespace collision because it sounds like it has to do with Drupal's block system.

Comment	File	Size	Author
#3	clearfix.patch	21.69 KB	eclipsegc
#1	drupal-clearfix-371231.patch	20.82 KB	johnalbin

Comments

Comment #1

johnalbin

they/他

English

Taipei, Taiwan

commented 8 February 2009 at 23:58

Status:

Active

» Needs review

Status	File	Size
new	drupal-clearfix-371231.patch	20.82 KB

Here's the patch that saves the kittens.

Comment #2

geerlingguy commented 10 February 2009 at 06:41

I like it - we'll need to make sure this gets into the theming handbook here on d.o as well.

On second glance, I still can't see any problems. It applies and all is well here.

Comment #3

eclipsegc commented 17 February 2009 at 13:32

Status	File	Size
new	clearfix.patch	21.69 KB

Rerolled against current head. I tested this out and things seem pretty good, but was not applied against two additional files.

modules/field/field.form.inc.orig (?? this doesn't appear in my patch, doesn't get unpatched when I reverse it, gets repopulated by cvs when I delete it, I assume this is some sort of file that's purely archival?)
themes/chameleon/chameleon.theme (is this getting removed in 7?)

Other than that it all looks good. I would have marked to RTBC otherwise.

Eclipse

Comment #4

boombatower commented 18 February 2009 at 02:55

Status:

Needs review

» Reviewed & tested by the community

No occurrences of clear-block left after this patch. Seems logical.

Comment #5

johnalbin

they/他

English

Taipei, Taiwan

commented 18 February 2009 at 03:09

Yes, my patch did miss the chameleon.theme file. Good catch, EclipseGC! I'll be more careful when letting BBEdit do global search and replaces. Note to self: click the "File Type: All File Types" toggle.

Comment #6

webchick

she/they

English

Vancouver 🇨🇦

commented 18 February 2009 at 14:28

Status:

Reviewed & tested by the community

» Needs work

Great. Committed to HEAD!

Please update the theme upgrade documentation.

Comment #7

webchick

she/they

English

Vancouver 🇨🇦

commented 18 February 2009 at 14:29

Issue tags:

+Needs documentation

Comment #8

add1sun commented 18 February 2009 at 14:29

Status:	Needs work	» Reviewed & tested by the community
Issue tags:	-Needs documentation

Just want to give a +1 to changing the name here. It is an odd drupalism that is just another bump on the road. Using the common terminology for this standard design fix makes way more sense to me.