Download & Extend

Infinite queue issues

Project:User Queue
Version:6.x-1.1
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Module is exactly what I needed for managing my guild's loot priority list. Thanks. :D

There seems to be an issue with the infinite queue size. It doesn't allow me to add users when I've set the size to 0 (infinite).

Comments

#1

Good catch - I realize now that I neglected to add special logic to ignore the queue length check if the length is 0. I'll fix that in the 6.x-1.1 version.

#2

Status:active» needs review

The fix is on line 465..

<?php
if (count($form_state['values']['users']) >= $form['#max_size']) {
?>

to
<?php
if ($form['#max_size'] > 0 && count($form_state['values']['users']) >= $form['#max_size']) {
?>

cheers,
Nick

#3

Version:6.x-1.0» 6.x-1.1

Still seeing this on the 1.1 version.

notice: Undefined index: users in /home/mrf/Sites/drupal6/sites/all/modules/userqueue/userqueue.module on line 465.
No additional users are allowed in this queue.