Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.So when you write a patch that (accidentally) breaks the Drupal installer, the testing bot returns with a cryptic message: "Failed: Failed to install HEAD". If you were writing a patch that dealt with the installer, a "Failed to install HEAD" message makes sense.
But, if you weren't writing an installer patch and given that the test bot is still a work in progress and that it has been known to break, that message sounds like the bot is broken. And could, hypothetically, lead to developers weeping in despair and saying “Why does the test bot hate me?” *cough* http://drupal.org/node/341140 *cough* Hypothetically.
A much better error message would be: Drupal installer failed to run after patch applied.
Comments
Comment #1
JohnAlbinIn IRC, chx said that it would be great if the bot could revert the patch to check that HEAD could still be installed. There would be no need to run tests, but a patch-less reassurance of HEAD installing would be reassuring.
Comment #2
boombatower CreditAttribution: boombatower commentedThe reassurance testing idea has already been discussed, implemented, and had issues.
PIFR 1.x will not utilize the code, but PIFR 2.x will have the feature in a usable state.
I'll make this change shortly and add to next release.
Comment #3
JohnAlbinLooks like the "Failed: Failed to install HEAD." message is still causing confusion. See http://drupal.org/node/394282#comment-1331406
Gentle bump. :-)
Comment #4
boombatower CreditAttribution: boombatower commentedI redid all the messages #381772: Update test summary messages to take environments into account and provide better detail and plan to add a link on the results page explaining possible fixes for a non-pass result.
For this case something explaining that the Drupal installer was broken by the patch and they should try and run it locally.