User Profile Image Using #value Instead of #markup

Ah! Yes the test was not functioning correctly. We need to actually switch to the user's profile page before checking for the image. So now we're fixing the test and the actual page. :)

Fixes a few code comments also.

Sorry this patch had some accidental code slip in. New patch coming up shortly.

This patch has higher accuracy for checking for the user profile picture, though it needs some rather funky code to properly check for the output of theme('user_picture'). Not so sure this is a "No brainer" any more. Silly tests.

Spacing fixes.

Okay... another shot at this. This time omit one of the user profile picture checks entirely, since we were checking for the exact same thing twice. Instead of checking for the whole image we're now checking just for the ALT tag.

I'm feeling like #5 was probably the best approach at this, but here's an alternative: don't use the silly l() function. The l() function is adding in the "active" class that's futzing up our comparison. We can remove it and hand-type the link to avoid the differences. This patch is more accurate than checking for the src or alt tags alone, since it actually renders the entire tag rather than checking for strings which might (though unlikely) show up elsewhere on the page.

Sigh. Okay here's the "short version". It works but will break when I introduce the imagecache patch. We'll fix it again then.

Oops, still some cruft in there from the last patch.

Thanks webchick, you're a star.