I've been playing around with this module for a while, and one thing that struck me is that all nodes are added to the nodehierarchy table, even though far from all (in my case anyway) have anything to do with nodehierarchy. This seems lika a waste to me. Idealy, only nodes that have a parent set should be in the table. I might be able to work on this if ronan feels it's worth it.

Comments

ronan’s picture

ronan commented
Status: Active » Closed (works as designed)

Older versions of the module did not save every node, but it turned out to be difficult to manage with regards to sort order, menu creation etc. I now add an entry for every node regardless of settings (so nodes with no parents are essentially at the root of the site, not lost in no-mans-land).

I'm going to mark this as by design, but if you are finding that it's causing any tangible issues on your site (performance penalties for example) reopen it and we can look at ways to mitigate them.

Thanks for the feedback
Ronan

blackdog’s picture

blackdog commented
Status: Closed (works as designed) » Active

Well, I'm back to this again. We have seen serious performance issues when the number of nodes have reached a higher number, about 30.000 now, and we 'solved it' temporarily by adding an index to the parent column as well.

I still don't think that it's the best thing to add all nodes to the nodehierarchy table, when only a small number of them are used.

vinoth.3v’s picture

vinoth.3v commented

HI

Please take a look into #576968: 6.x-1.x -> 6.x-2.x Upgrade Path too

markhalliwell’s picture

markhalliwell
Primary language English
commented
Component: Code » Drupal/PHP Code

Copy & Pasted: This issue pertains to the 6.x-1.x branch which is now legacy and is over one year old. If this issue is not applicable anymore, please consider closing it. Otherwise, please update this issue appropriately. Will be closed in two weeks if no response.