By sepeck on

So, I spoke with Dries about this and he said go ahead.

There are some reported issues with 4.6.3 and php5 (and misc other stuff). Let's see if we can get some folks to look at the issues for 4.6.3 and any that have patches for them, test (only test 4.6.3 not HEAD) and review. Pay paticular attention when you comment.

Dries said if we can get some good reviews on pending patches he is willing to release a Drupal 4.6.4 soon. If we can get this down early enough this weekend (Saturday night), maybe we can get this done before his business trip.

I have more news about a 4.7 release candidate timeline, but will post seperately. In the meantime, lets see if we can get some quality reviews on pending patches (or some more patches to review as well)

Comments

dries’s picture

dries commented

In addition to testing DRUPAL-4-6 against PHP 5.0.x, I'd like to encourage people to test DRUPAL-4-6 against MySQL 5. Thanks.

jakeg’s picture

jakeg commented

I'm using 4.6.3 on PHP5/MySQL 4.1, and had a problem with the log message (e.g. 'content updated', 'path alias added' etc) persisting until the user logged out. This was fixed by a patch I found - http://drupal.org/node/21364

Can't wait until more modules work with 4.7/HEAD though and that's released! I have been using 4.7 for testing purposes for months now, but too many contributed modules still need updating (e.g. forms api) before they can be used with 4.7, so I had to go back and use 4.6.3 for this survey - http://survey.estateangels.co.uk . It was painful the lack of some features I'd come to expect in 4.7/head that weren't available in 4.6.*. And the inclusion of primary_links in head now makes the prospect of a 4.7 launch even more exciting!

gordon’s picture

gordon commented

This is actually a known problem with the xtemplate engine. If you change to phptemplate then the problem goes away.
--
Gordon Heydon
Heydon Consulting

--
Gordon Heydon

jakeg’s picture

jakeg commented

Ok, that's fine. But download 4.6.3 as someone who doesn't know this, use the default template and it doesn't work. Phptemplate isn't even included with 4.6. Not a good experience for potential new users.

rbrooks00’s picture

rbrooks00 commented

It is included (and the default engine I believe) with 4.7 so I guess there isn't a problem going forward. If it isn't a ton of work it seems like it would make sense to change this in 4.6 if a .4 version is being entertained.

============================================
BuyBlue.org

sepeck’s picture

sepeck commented

Support is current release and one past so if someone can supply a patch to fix (or if it is already there) then it would be a good thing.

-sp
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide

dries’s picture

dries commented

Is there an issue with more background information (and a patch)?

gordon’s picture

gordon commented

No AFAIK there is no more information. I found this problem, and didn't get around to fixing it. But when I installed phptemplate the problem went away.

However the funny thing is that on my server here at home I didn't have an issue which is running 5.0.5, but I hosting company did have a problem.
--
Gordon Heydon
Heydon Consulting

--
Gordon Heydon

peterx’s picture

peterx commented

My test system works with PHP 5.0.5 Win32 using the mysql extension. I am using the following Drupal modules. Book, comment, distantparent, excerpt, forms, help, massmailer, menu, node, page, path, pet, phplist, poormanscron, statistics, story, survey, taxonomy, taxonomy_menu, trip_search, upload, and vocabulary_node.

petermoulding.com/web_architect

petermoulding.com/web_architect

dries’s picture

dries commented

What Drupal version are you using? Drupal 4.6.3 or DRUPAL-4-6 (CVS)?

peterx’s picture

peterx commented

petermoulding.com/web_architect

petermoulding.com/web_architect

peterx’s picture

peterx commented

I had to replace $theme = array_pop(explode('.', arg(3), 2)); with the following from 4.7.

$reference = explode('.', arg(3), 2);
$theme = array_pop($reference);

Ditto:
file_check_directory(variable_get('file_directory_path', 'files'), FILE_CREATE_DIRECTORY, 'file_directory_path');

petermoulding.com/web_architect

petermoulding.com/web_architect

dries’s picture

dries commented

That problem will be fixed in Drupal 4.6.4. See http://drupal.org/cvs?commit=19177.

If possible try testing the head of the DRUPAL-4-6 branch:
$ cvs co -r DRUPAL-4-6 drupal

killes@www.drop.org’s picture

killes@www.drop.org commented

Maybe we should generate Drupal-4-6 cvs tarballs for a limited amount of time.
--
Drupal services
My Drupal services

--
Drupal services
My Drupal services

fago’s picture

fago
Primary language German
Location Vienna
commented

perhaps it's time to fix this issue now:
http://drupal.org/node/29548 :)

m3avrck’s picture

m3avrck commented

Guys, I just wrote a patch that also fixes numerous problems when using MySQLi (I believe MySQL 5 only uses this and not the older mysql, correct me if I am wrong though).

Please have a look, patch is very simple but fixes a lot of errors!

http://drupal.org/node/36828

peterx’s picture

peterx commented

petermoulding.com/web_architect

petermoulding.com/web_architect

tomcalloway’s picture

tomcalloway commented

Thanks for your good work and that of the community on this.

With these changes Drupal will be able to take advantage of the performance improvements in MySQL and PHP's latest/upcoming releases.

dries’s picture

dries commented

I just committed this patch but it's only for Drupal HEAD (the forthcoming Drupal 4.7.0 release) and not for Drupal 4.6.4.

skri11a@drupal.org’s picture

skri11a@drupal.org commented

Thought I'd add my experience/problem...

I'm using Drupal 4.6.3
Fedora core 4
Apache 2 and 1.3 (using ispconfig)
mySQL 4.1.14
and finally PHP 5.0.4

I am getting the error:

Fatal error: Only variables can be passed by reference in /var/www/web1/web/modules/node.module on line 713

Everything I've read suggests this shouldn't be a problem with 5.0.4

*edit*
Sorry, this is happening in the administer => content => configure = > content types => 'any' configure page.

peterx’s picture

peterx commented

Replace

      $items[] = array('path' => 'admin/node/configure/types/'. arg(4),
        'title' => t("'%name' content type", array('%name' => node_invoke(arg(4), 'node_name'))),
        'type' => MENU_CALLBACK);

with

$arg_4 = arg(4);
      $items[] = array('path' => 'admin/node/configure/types/'. arg(4),
        'title' => t("'%name' content type", array('%name' => node_invoke($arg_4, 'node_name'))),
        'type' => MENU_CALLBACK);

petermoulding.com/web_architect

petermoulding.com/web_architect

skri11a@drupal.org’s picture

skri11a@drupal.org commented

Worked like a charm!

Can't tell you how much I appreciate that.

Thanks, again.

dries’s picture

dries commented

If this needs fixing in DRUPAL-4-6, please provide a patch. I'm not saying that Peter should provide this patch. Someone else can turn this into a patch, if necessary. I plan to release Drupal 4.6.4 in the next few days, so better be quick. Thanks folks.

drewish’s picture

drewish commented

http://drupal.org/cvs?commit=19177