Cool module, but needs 6.x version

CommentFileSizeAuthor
#2 bouncer-6.x-1.0.zip12.01 KBguillaumeduveau

Comments

skiminki’s picture

Status: Active » Postponed

Yes it does. However, I'm currently buried in other stuff. If anyone wants to make some porting effort, that'd be much appreciated.

guillaumeduveau’s picture

Assigned: Unassigned » guillaumeduveau
Status: Postponed » Fixed
StatusFileSize
new12.01 KB

Here it is !

I was looking for a module for affiliate links and I thought I could use Bouncer as a starting point so I did the port.

However I believe that for an affiliate link module, some deep modifications must be made to Bouncer, like :
- allow the admin to enter a collection of affiliate links with for each :
- a keyword
- a link
- scan the nodes to replace the occurences of the keyword by the affiliate link
- cloak the URL of the affiliate link
- adapt the reports
- later : customization of link class, attributes, ...

See also : #399436: Affiliate link module ?

skiminki’s picture

Status: Fixed » Needs review

Nice! I'll try this out in the next couple of days and if no blockers show up, expect commit and release.

guillaumeduveau’s picture

Hi skiminki,

Great ! Otherwise what is your vision of Bouncer's future ? Should I collaborate with you on Bouncer or start a new module ?

Thanks
Guix

skiminki’s picture

Status: Fixed » Needs review

Committed D6-port by guix (see note 2):
http://drupal.org/cvs?commit=183738

The port looked solid, and actually seems to bump up a bit the overall code quality compared to my D5 code base :)

However, I found out the following minor annoyances that need to get fixed before release:

  • Bouncer reporting: Bouncer report tab link does not work
  • Bouncer reporting: End date is off by 1. The end date should be inclusive and now it's not. I'm not quite sure how that was in 5.x version, but anyways...

I'm going to fix these.

skiminki’s picture

Status: Needs review » Fixed

The fixes mentioned above:

So, these applied, the RC1 is out! I'm going to wait a week and create the official if no blockers show up.

Reply to #4: I have nothing planned as the current functionality suits perfectly for my purposes. I think that the D5-version should stay in the bugfix-only mode. However, if you want to extend the functionality of the D6 version I'm more than willing to apply patches, as long as the current functionality is included. I could even give you the co-maintainership for this module if you want it.

guillaumeduveau’s picture

Status: Needs review » Fixed

Hi Skiminki,

Yes I agree with the D5 version bugfix mode. I'm a bit busy now but later in the year I should have a website with affiliate links, so when I have a chance I'll look into adding the features I was talking about. Don't know where however, I just discovered URLproxy.

Thanks for the module and for commiting the port !

skiminki’s picture

One additional fix concerning date handling and daylight saving time, i.e., don't assume that day is exactly 86400 seconds:
http://drupal.org/cvs?commit=187884

Now I think we can make 6.x-1.0.

guillaumeduveau’s picture

Thanks a lot Skiminki, keep up the good work :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.