When id parameter is passed into swf() function inside $othervars array, it is inserted into

tag as "othervars['id']) ? 'othervars['id'] .'" />'."\n" : ''; needs to be replaced with $id = ($vars->othervars['id']) ? 'id="' . $vars->othervars['id'].'" ' : '';

Comments

coil.uk’s picture

coil.uk commented

Sorry, for the wrong formatting in the original submission. It should be like that:

When id parameter is passed into swf() function inside $othervars array, it is inserted into the <object> tag as '<param name="id" value="[id value]>' rather than taking the form of ' id="[id value]" '. This breaks HTML markup of the object tag.

In order to fix that, the following line inside the function sfwtools_swftools_embed() in swftools.module

$id = ($vars->othervars['id']) ? '<param name="id" value="'. $vars->othervars['id'] .'" />'."\n" : '';

needs to be replaced with

$id = ($vars->othervars['id']) ? 'id="' . $vars->othervars['id'].'" ' : '';
Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Active » Needs review

Fixed locally, pending commit to repository. This bug is present in all versions of SWF Tools - fixed in all branches.

Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Needs review » Fixed

New releases made so this fix is now in place in the official packages.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.