TinyMCE 3: extended_valid_elements merged wrongly

I had a problem with TinyMCE and the advanced image button (assume this it the same with the basic one, but I've not checked it). There's no extended_valid_elements array item that includes the img tag.

I've created a workaround for the issue, which I've verified, but it's a nasty hack:

sites/all/modules/wysiwyg/editors/tinymce.inc

Find the code that starts:

// Clean-up.
$init['extended_valid_elements'] = array_unique($init['extended_valid_elements']);

From what I can work out, this is used to make sure that any 'extended_valid_elements' that are added by plugins aren't duplicated. I found that adding in an extra line to allow for advanced image-formatting did the trick, changing the code to:

// Clean-up.
$init['extended_valid_elements'] = array('img[class|style|src|border=0|alt|title|hspace|vspace|width|height|align|onmouseover|onmouseout|name]');
$init['extended_valid_elements'] = array_unique($init['extended_valid_elements']);
$init['extended_valid_elements'] = array_unique($init['extended_valid_elements']);

This may have been solved in one of the dev versions, or I'm happy to submit a patch, if you can point me in the right direction for where this code should go. Seems like it should be included int he tinyMCE settings in WYSIWYG as the basic/advanced image buttons ship with the editor as standard.

Also, it looks like the code that the settings for $init['extended_valid_arguments'] is set to an empty array, when iterating through the user plugins. Might make sense for a global setting to include the standard tags used by the buttons that TinyMCE ships with.

Happy to help, if I can. Hope this is useful.

Toodle Pip

Sam
http://www.toodlepip.co.uk