The introduction of some constants to refer to the supported streaming metods (FLASHVIDEO_STREAMING_METHOD_RTMP, FLASHVIDEO_STREAMING_METHOD_XMOOV) did not follow through to all of the streaming module's code.

Attached patch rectifies this (I think I got all the references)

CommentFileSizeAuthor
flashvideo-constants.patch8.72 KBmrfelton

Comments

attheshow’s picture

attheshow commented
Title: Streaming settings not saved » Adding Contants to Streaming Module
attheshow’s picture

attheshow commented
Category: bug » feature
attheshow’s picture

attheshow commented
mrfelton’s picture

mrfelton commented
Category: feature » bug

This is actually a bug. The constants are already in the current -dev version, but are only used in a couple of places. They need to either be used properly (everywhere where their values are referred to) or not used at all. Currently the code is checking for the value or 'RTMP' or 'xmoov', but these are never actually set because the constants are used in the form element that is supposed to set them.

For example, this will not currently work:

if($form_state['values']['flashvideo_'. $node_type .'_streaming_enable'] && $form_state['values']['flashvideo_'. $node_type .'_streaming_method'] == 'RTMP') {

But this will:

if($form_state['values']['flashvideo_'. $node_type .'_streaming_enable'] && $form_state['values']['flashvideo_'. $node_type .'_streaming_method'] == FLASHVIDEO_STREAMING_METHOD_RTMP) {
attheshow’s picture

attheshow commented
Status: Active » Fixed

Thanks. I didn't notice you had inserted those constants in some of the previous code. Should be fixed now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.