The streaming module now requires to know $node_type for it's hook calls to work properly. These are not being passed from flashvideo.module. Attached patch is only tested for the xmoov-php streaming method and I have probably missed something/done it wrong - I just needed to get it working real quick.

CommentFileSizeAuthor
flashvideo-streaming-hook-ammends.patch2.47 KBmrfelton

Comments

attheshow’s picture

attheshow commented
Assigned: Unassigned » attheshow
Priority: Critical » Normal
Status: Active » Fixed

Was related to an incorrect commit from a few days ago. Fixed today.

mrfelton’s picture

mrfelton commented
Status: Fixed » Active

Sorry, I'm reopening this one. The call to flashvideo_get_file() in flashvideo.playlist.inc at about line 89 is still missing the node_type paramater:

       // Give other modules a chance to override...
        if (!($filepath = module_invoke_all('flashvideo_get_file', $file))) {
          $filepath = check_url(file_create_url($output_dir . basename($file->filepath)));
        }
attheshow’s picture

attheshow commented
Status: Active » Needs review

Ok, I just committed an attempt to fix this on the playlist. Can you check it out and see if this change works?

attheshow’s picture

attheshow commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.