Kill box.tpl.php / theme_box()

Die! Die! Die!

i.e. +1

+1, and subscribing.

I have always wondered what the real purpose of this was. I wholeheartedly agree. +1

+1
no more surprise markup from unneeded theme_box implementations.

Yep.

OK. I'm keen to give it a go. Can someone point me to what it should be replaced with?

I'd recommend creating a theme function in the comment module to handle theme the comment box and another theme function for the search results.

The theme functions need to be registered by hook_theme and then theme_box can be removed.

+1 Subscribing. Would love to kill the box.

Box has been killed.

I created a theme_search_results_listing() for the search.module and replaced comment_form_box() with a theme_comment_form_box() for the comment.module.

Committed to CVS HEAD. This needs to be documented in the upgrade guide. Mark as 'fixed' after it was documented. Thanks!

Cool.

Do you mean the 6.x to 7.x theme upgrade page or the http://drupal.org/upgrade/ handbook? I don't know the handbooks very well, but I can document this change if someone can point me somewhere. Thanks.

@JamesAn: Yep, the former: http://drupal.org/node/254940

You look like someone who knows how to apply a patch! ;)

So how do you do it? Is there some Drupal module for it, some utility with a GUI, or is it some command line script that I need to execute?!

Also, there must be some utility for actually creating the .patch files as well. Can you direct me to one?

Thanks!

http://drupal.org/patch/apply = how to work with patches.

Thanks very!

Strange.. What's box.tpl.php doing in the system folder? Not sure how it ever got in there when we had the theme function.

Joon, I had the same problem with a file in Views. That file was modified in a DRUPAL-5 branch when I ran a cvs up -AdP (which moved me to HEAD). But it remained in my checkout even though it wasn't in HEAD; worse, it didn't show up as an unknown file in HEAD (with a preceding ? mark). I really hate CVS sometimes. Try deleting modules/system/box.tpl.php and running cvs up again. It should stay removed.

I updated the upgrade docs. http://drupal.org/node/254940#box

Thanks John for updating the docs. I hadn't gotten to it yet.. ^^"

I must be on the wrong branch. It's listed as "HEAD" for sticky tag. I removed the template, updated and box.tpl.php was pulled back in. I really hate CVS. Always!

Thanks John.

Ok, I just looked at this again. Joon is right. box.tpl.php really is still in CVS. See: http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/system/

Looks like it wasn't removed: http://drupal.org/cvs?commit=199904

Please remove.

Deleted!

I do! I do! ;-)

Thanks. :)

DIE, box.tpl.php, DIE!!

Is it expected behaviour that block.module still installs the {box} table?

Is it expected behaviour that block.module still installs the {box} table?

Yep. But that's a separate issue. The fact that blocks are stored in a box table is unrelated to the issue of removing theme_box/box.tpl.php as block module didn't use those.

subscribing

The upgrade guide has not been updated: the is no mention of a recommended upgrade from theme('box').

Additionally, when done, this issue should be passed on to coder_upgrade (coder.module) as it does not have an upgrade path for theme('box') either.

tagging for upgrade guide

The theme update guide was already updated:
http://drupal.org/node/254940#box

So I guess what is being asked for in #31 is an update to the module update guide... so I added:
http://drupal.org/update/modules/6/7#theme_box