Guys,

The drupal_set_html_head function, on includes/common.inc, line 132, is misleading: it does not SET, but ADD HMTL header data. It would be much more adequate to rename it to drupal_add_html_head.

regards,

massa

CommentFileSizeAuthor
#2 rename_drupal_set_html_head.patch4.2 KBRace.it

Comments

Race.it’s picture

Race.it commented
Assigned: Unassigned » Race.it
Race.it’s picture

Race.it commented
StatusFileSize
new rename_drupal_set_html_head.patch4.2 KB
Race.it’s picture

Race.it commented
Status: Active » Needs review
stewsnooze’s picture

stewsnooze
he / him
commented

subscribe

dries’s picture

dries commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. Marking it RTBC -- will commit it later (unless someone objects).

Zarabadoo’s picture

Zarabadoo commented

This makes perfect sense to me.

crashtest_’s picture

crashtest_ commented

Just commenting that it makes more sense this way. Good change.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Quick fix, +DX (Developer Experience), +Needs documentation

I asked for some themers/designers in #drupal-design to +1 this change, and they did so committed to HEAD. Makes a lot of sense to me, too. :)

I'm marking needs work now because this needs to be documented at http://drupal.org/node/224333. @cytefx, once you've done that, could you please mark this issue to 'fixed'?

Race.it’s picture

Race.it commented
Status: Needs work » Fixed

Updated the document to have the following comment

The function drupal_set_html_head() has been renamed to drupal_add_html_head().
(issue) In Drupal 6, the drupal_set_html_head() function, is misleading: it does not SET, but ADD HMTL header data. In Drupal 7, it has been renamed to drupal_add_html_head().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

This made base core API pretty confusing. See #451604: Rename drupal_set_header().