Closed (fixed)
Project:
JQuery menu
Version:
6.x-2.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Feb 2009 at 09:36 UTC
Updated:
16 Nov 2009 at 07:42 UTC
We changed the theming function to hide the +/- spans and so we could use the links to open/close the tree. We had to make 2 changes to the js files:
1/ $(this).find("li.parent a.parent").click(function(){
2/ add return false; to stop processing the href
New code for jquerymenu_no_animation.js
// $Id: jquerymenu_no_animation.js,v 1.2 2009/02/04 21:54:54 aaronhawkins Exp $
Drupal.behaviors.jquerymenu = function(context) {
$('ul.jquerymenu:not(.jquerymenu-processed)', context).addClass('jquerymenu-processed').each(function(){
$(this).find("li.parent a.parent").click(function(){ // <- changed
momma = $(this).parent();
if ($(momma).hasClass('closed')){
$(momma).removeClass('closed').addClass('open');
$(this).removeClass('closed').addClass('open');
}
else{
$(momma).removeClass('open').addClass('closed');
$(this).removeClass('open').addClass('closed');
}
return false; // <- added
});
});
}
New code for jquerymenu.js
// $Id: jquerymenu.js,v 1.5 2009/02/04 21:54:54 aaronhawkins Exp $
Drupal.behaviors.jquerymenu = function(context) {
$('ul.jquerymenu:not(.jquerymenu-processed)', context).addClass('jquerymenu-processed').each(function(){
$(this).find("li.parent a.parent").click(function(){ // <- changed
momma = $(this).parent();
if ($(momma).hasClass('closed')){
$($(this).siblings('ul').children()).hide().fadeIn('3000');
$(momma).children('ul').slideDown('700');
$(momma).removeClass('closed').addClass('open');
$(this).removeClass('closed').addClass('open');
}
else{
$(momma).children('ul').slideUp('700');
$($(this).siblings('ul').children()).fadeOut('3000');
$(momma).removeClass('open').addClass('closed');
$(this).removeClass('open').addClass('closed');
}
return false; // <- added
});
});
}
Comments
Comment #1
PixelClever commentedIf you want links like this then you should be using Dhtml menus.
Comment #2
attiks commentedI forget so mention that I'm using http://drupal.org/project/taxonomyblocks so Dhtml menu isn't really a solution for me.
Comment #3
PixelClever commentedI really don't have any intention of changing this or adding the option. I consider this bad practice as it breaks the patterns of normal user interaction with links. Also this would add problems for other modules using the JQuery menu module and I don't want to try to maintain an unintuitive interface across several modules. Most people I have talked to hate the double click "feature" of Dhtml menus, I would seriously suggest doing user test with both side by side and see which the average joe prefers. When I land on a site with the Dhtml module installed I can't get off of it fast enough. If I didn't have such a distaste for that interface I wouldn't have spent the scores of hours developing this module. I'm sorry, but this decision is set in stone.
Comment #4
attiks commentedNo problem, I created a separate js file in my theme with the necessary js code
Comment #5
rjdempsey commentedSorry to re-activate this thread but we could really use this functionality too. We DID do usability testing and in our case this would improve usability. I understand it would not in most cases but in ours it would.
We are not using DHTML menu because we are using Advanced Taxonomy Block which we think is really great in many ways. In our site, parent taxonomy terms are used simply as headings for child in terms. No nodes are ever tagged with the parent term, only the child terms. Advanced Taxonomy Block is perfect in that it tallys up node count for child terms and applies it to the parent term. Example:
Parent Term (3)
--Child Term (1)
--Child Term (1)
--Child Term (1)
Thats great, but the usability issue we're facing is we're wasting the users time having them click on a parent term and having it's page loaded when there is NEVER any nodes tagged as such, they ALWAYS, come to a blank page. The users have found this confusing to see the page reload and be led to a blank page.
It would be better if the Parent Term simply expanded the children. Then it would be immediately obvious to the user that they are meant to select a child term.
Thanks!
Comment #6
kentjames1980 commentedI agree totally , Ive just finally figured out how to get the taxonomy menu to work but i have ubercart and i dont want the user to click onto the root folder of the sub category products - just onto the product sub categories themselves. Is there a way to do this? Im not that drupal minded yet as ive only been doing this for a month.....Any advice would be greatfully recieved....
EDIT - scrap that - ive just realised i can make the products within that section all appear when the root is clicked and it kinda works well in that configuration - would be a useful extra though!
Comment #7
PixelClever commentedThis option will never be added unless you can create a patch (not a code snippet) that offers this functionality as a secondary option that is turned off by default. The patch must be a 100% valid patch made against the latest 3x version that will soon come out. It must implement the code following Drupal coding standards and it must not disable, alter or remove any functionality on the module unless the user chooses to do so on the administration page.
If you post such a patch and when and if such a patch has been tested by the community for some time then I will look at it. I have no interest in this functionality, so whoever wants it is going to either have to either do it themselves or contract a programmer to do it. I will do it for $650 USD but not for less. Anyone wishing to pay me to do it can send me an email through my profile page. Do not open this thread to haggle the price or to beg or to "+1" it, my position is firm.