Node does not get updated when followed the link of content_complete block

Data editing is not altered by this module, it only will give you the message "Please complete the fields" but won't actually do something. We either need more info on this, or I think its most likely generated by one of the custom modules. Anyone something similar with the described setup?

It seems the use of form_set_error to flag a field as incomplete is creating a problem for your specific installation:

$fieldname = $_GET['content_complete_fieldname'];
form_set_error($fieldname, t('Please complete the fields.'));

This is rendered for every form that has an argument 'content_complete_fieldname' in the URL.

I used the form_set_error more for convenience (displaying a user message + showing a red line around the box to be completed), and it shouldn't actually fail validation, although I am not entirely sure of that...

I also get the same problem - when following a link to fill out one of the missing fields the form wont work, the field isn't saved and displays the "Please complete the fields." message. Since it doesn't happen when you go to the normal edit page without the extra destination in url from the content complete link it must be to do with that. Will try the fix suggested above.

Am also using APK so that may be related, but not sure what difference it makes.

Would also be interested in knowing if the user can be redirected back to the panel they started on rather than node page.

Thanks

I tried to replicate the problem with advanced_profile and content_profile. However everything seemed to work fine.

Can anyone specify better the problem, or describe in detail the setup? It might have something to do with the type of form element, so far I only tested with a textfield.

I'm having the same issue using content_profile.

form_set_error() is used by validation handlers to notify the forms API that the form failed validation, so it will keep the form from being submitted.

I'll take a look at what might be causing this to happen only in certain cases, but I would recommend not using form_set_error().

I used form_set_error to draw a red bar around the field that needs to be completed.

An alternative is to use the class ID of the field and draw a red line around the field with inline JS (like in the pcp module, line 92). For Content Complete however the fields are more diverse (CCK fields, or core title/body), and it is more complex to get the correct field names. form_set_error did the heavy lifting for me, but apparently in certain circumstances this does not validate anymore (although I never managed to replicate it myself).

If you have an idea of how to do this without form_set_error, I would be glad to know.

Hi,

I'm having the same problem. The field isn't updated.

I think the problem appears because the generated form, when the "follow link" was clicked, has the same url as the form action URL of this form. An example:

I click over the Block link "fill up name ..." and then I'm redirected to a url like this "http://www.mydomain.com/node/367/edit?content_complete_fieldname=field_name". The field "name" is inside a red box, and I can see a message in order to complete the field. If you look for the destination url form, you can see something like this: '

Hope this can help to resolve the issue!!

Great job any way!!
Ricardo

Same problem here. I'm using Content Profile and Panels to display a profile page with two content types.

Changing form_set_error to drupal_set_message solves the problem of not saving the node. But now the field-name is displayed on top of node, and that's not really cool. So, are there any other alternatives?

Anyway, thanks for this wonderfull module.

Subscribing.

Thanks for the great module.

I'm using the Drupal 6.12 and have couple of content type which have been marked as content profile.
Whenever we follow the "Filling out FIELD NAME will bring CONTENT TYPE NAME to xx%"
and even if we fill or not fill that FIELD NAME, the node does not get updated. It constantly throws an error of "Please complete the fields."

If we do comment the line of form_set_error

  $fieldname = $_GET['content_complete_fieldname'];
   //form_set_error($fieldname, t('Please complete the fields.'));

It works.

But we also need to have another way out to prompt the user to fill that FIELD NAME. Also making sure It is not to make it required field (If it is optional in the defination)

I was just working around it and found that on form submit it also calling the form_set_error

Just checkout the patch attached. It works for me.

Thanks for the patch, this will likely solve the problem, and I've committed it to dev. I'm marking this issue as fixed.

Thanks for applying it to dev.