OGUR v5.3 with OG v8.0 error on userprofile page

Hi there,

It's drupal v5.15 and node.module version:

// $Id: node.module,v 1.776.2.33 2009/01/14 23:32:14 drumm Exp $

The lines 563 and 567 are refering to the node_load function:

function node_load($param = array(), $revision = NULL, $reset = NULL) {
  static $nodes = array();

  if ($reset) {
    $nodes = array();
  }

  $cachable = ($revision == NULL);
  $arguments = array();
  if (is_numeric($param)) {
    if ($cachable && isset($nodes[$param])) {
      return is_object($nodes[$param]) ? drupal_clone($nodes[$param]) : $nodes[$param];
    }
    $cond = 'n.nid = %d';
    $arguments[] = $param;
  }
  else {
    // Turn the conditions into a query.
    foreach ($param as $key => $value) {                             <----------- line 563 
      $cond[] = 'n.'. db_escape_table($key) ." = '%s'";
      $arguments[] = $value;
    }
    $cond = implode(' AND ', $cond);                             <----------- line 567
  }

  // Retrieve the node.
  // No db_rewrite_sql is applied so as to get complete indexing for search.
  if ($revision) {
    array_unshift($arguments, $revision);

I did some code digging and discovered a piece of responsible code in og_user_roles.module, somewhere around line 1500:

/** --DD-- ERROR ON USER PROFILE PAGE
  // Add the group roles to $user->roles if this is a group
  // This should only be effective until the next global $user call
  if ($op == 'load') {
    $roles = og_user_roles_all_roles($user); // This returns normal $user->roles and includes OG roles if any
    $user->roles = $roles;
  } // end $op load
**/

Commenting that out takes away half of the error message. But I still dont understand what going on there...
I hope to get the code straight to fit to OG v8.0 (was migrating from OG v7.3).

replying...

Here you go.
The error message at URL /user/16 and attached the output of og_user_test table at that URL.

<sub>* warning: Invalid argument supplied for foreach() in /var/www/virtual/intra/htdocs/modules/node/node.module on line 563.
* warning: implode() [function.implode]: Bad arguments. in /var/www/virtual/intra/htdocs/modules/node/node.module on line 567.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /var/www/virtual/intra/htdocs/includes/database.mysql.inc on line 174.
* warning: Invalid argument supplied for foreach() in /var/www/virtual/intra/htdocs/modules/node/node.module on line 563.
* warning: implode() [function.implode]: Bad arguments. in /var/www/virtual/intra/htdocs/modules/node/node.module on line 567.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /var/www/virtual/intra/htdocs/includes/database.mysql.inc on line 174.</sub>

Hi there, that's good news.

But I just updated to v3.6 and found that the og_user_roles.module is the same than in v3.5 ?