Global option for batch settings
nonsie - February 11, 2009 - 18:37
| Project: | Domain Access |
| Version: | 6.x-2.x-dev |
| Component: | - Domain Conf |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
It might not be use case for most DA users but in some cases the domain list can get very long and marking each domain offline to perform updates is quite tedious. Attached is patch we've been using to simplify this - it alters the description text at the top of the page and provides options to switch all sites online or offline (eg mark the correct radio button). You'll still need to save the form.
| Attachment | Size |
|---|---|
| domain_conf.module_toggle_offline.patch | 1.72 KB |
#1
I wonder if this can be abstracted to some of the other forms?
Or maybe we should just provide a global option at the top of the form? "Set all to this value"
#2
This is another nice-to-have but not critical improvement.
#3
I was just about to code this myself but decided to search first - good stuff! Patch didn't apply, so I re-rolled.
I agree that we should try to make this a generic function, so more batch updates can use it, or we create domain.js and put all this stuff in there, and create these helpers where they fit.
#4
Bumping to 'needs review' so people can see it, but I don't intend to work on this right now.
#5
Which approach would you prefer to take with this?
Provide one global option for all batch operations?
Or create helper snippets like the one attached for those areas that users find needing it?
#6
I like the global option. Maybe at the top of the form, a global option, with checkboxes (which can be mass selected) for each entry.
Something like the hook_node_operations() does with admin content.
#7
Here's a new patch making this a general form function on all batch forms. It takes the setting that's being displayed and creates a new form item which lets users update the value and check to apply it to all domains.
I haven't figured out why I can't get this form to show up before the domain table, any ideas?
#8
Updated patch to make strings translatable.
#9
Yes, see
theme_domain_batch_form(), which specifies the rendering of the form. Using a theme function in this way can override #weight elements in the form.I think we want the option to ignore certain domains here. And I'd really like for nonsie to review.
#10
#557494: Easier batch updating was just marked as a duplicate of this issue. As such, I've renamed the title to better suit the discussion here.
#11
This patch is dead sexy.
I cleaned up some of the options, moved the form element in the theme function, and also corrected a few stray domainbatch errors.
I did not implement the 'skip some domains' feature, as I figure people can handle that themselves.
This added an element to the hook_domainbatch() API, since some values _must_ be unique across all domains, we do not allow them to be set with this form.
the value
#udpate_allhandles this. It must be set to TRUE for this form field to be visible.Committed to HEAD!
#12
We no longer force site name to be unique, so that can be set for all, as well. I think the only thing that can't is the domain string itself.
#13
Good stuff Ken! Great work on the 2.0 release!
#14
Automatically closed -- issue fixed for 2 weeks with no activity.