Order administration form + AHAH

The order edit screen on your sandbox is empty ... also cannot create order @ /admin/store/orders/create the user-lookup and add new user appear to be broken. Still havnt tried it on my server.

Just a question though ... doesnt the order screen already have AHAH or AJAX or sompin? Whats the diff in your implementation?

Are you rolling your patch against the latest bzr? Your patch did not apply cleanly. It'd be super awesome if you could reroll it... =)

Ah, I see. I don't maintain a CVS branch of Ubercart, but I guess I probably should...

bzr stands for Bazaar, the revision control we use for development... Let's see if I can apply this patch to CVS and reroll it for the latest bzr... we shall see!

P.s. Just by eye review, I see you have a couple $form_state['rebuid'], which I assume should be 'rebuild' =)

Well, I pulled CVS HEAD (Don't do that, apparently ;)) and -r DRUPAL-6--2, but none of them would apply the patch cleanly. What CVS tag/branch did you roll off of..?

Yeah, HEAD for Ubercart is kinda screwy... do it against the DRUPAL-6--2 branch if you do it from CVS, although doing it from the latest Bzr is really best.

@ neochief ... the edit screen is blank (in your sandbox).
When clicking edit on one of your existing orders the tab is selected but there is no form underneath it.

Firebug shows nothing on the page but main page structure.

EDIT: Nevermind there was something wrong with my browser ... for some reason your website and @ ubercart.com no forms would render! Strange.. anyhoo restarting the browser fixed it for me.

Awesome, I got it to apply. It'll be a little bit before I can do a proper review/testing on it, though I gave it a lookover...

I hate to break it to you, but the patch no longer applies to DRUPAL-6--2. There were changes made to uc_order.js (and elsewhere) to allow products with attributes to be added to orders correctly. When I tried to work around this and apply the patch, no products were listed on the order-edit page. I didn't see if the buttons actually worked, so you might not have to make too many changes.

Patch applied cleanly and is on the Livetest apparently working fine. I'm not entirely sure what all I should be testing for this, though. Any chance we can get a comprehensive list of features to test to make sure it's all working fine in our sites?

I did some brief code review and saw at least one thing that I'd ask for a fix even though 'twas a copied line of code... there's at least one instance of using double quotes with an embedded variable that I'd like to have turned into a concatenated single quote string... it's in one of the form elements:

-        '#name' => "products[$i][remove]",
-        '#theme' => 'uc_order_remove_product',
-        '#parents' => array(),
-        '#img_id' => $products[$i]->order_product_id,
+        '#type' => 'image_button',
+        '#id' => $products[$i]->order_product_id,
+        '#name' => "products[$name][remove]",

The recommended change is '#name' => 'products['. $name .'][remove]',.

Here's a reroll against the tip of the Bazaar repository. I really do recommend getting Bazaar and getting updates from our repository. It only took me a few minutes to make a new branch based off the way Ubercart was back in March, apply your patch, and merge those changes in to the latest code. There were only two conflicts in uc_order.admin.inc, and I knew how to take care of them since I had studied what your patch was doing.

This should help us work together on this since I can keep committing bug fixes, and you don't have to work nearly so hard to keep up with them. If you want, I can post up some detailed instructions and maybe even set up repositories for us to swap merges back and forth.

I'm marking it as needs work because the line items, particularly subtotal and total, aren't updated when I click "Save changes" after adding products. The new products are actually saved, because they still appear on the view tab, even without clicking "Save changes", which is how it worked before.

It's kind of late to put a lot of changes under the hood into the 2.0 release. I think for 3.x, we'll have better tools (Chaos tools, no less ;) ) for AHAH and such, so we should definitely start using them then.

This has all been AJAXified in D7 already and is too big a change to backport to D6 now.