Closed (fixed)
Project:
Ubercart
Version:
6.x-2.0-beta5
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
12 Feb 2009 at 22:02 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent, Most recent file
This is kind of an over-arching issue to deal with a bunch of problems on the product report page. If you can deal with one thing in its own patch, post it up to it's own issue, and we'll cross it off the list here.
- #373634: Product reports don't display all SKUs.
- #371901: Product reports are using br tags instead of table rows
- Report columns aren't really sortable.
- Separate queries for MySQL and Postgres for no reason.
- Lots of duplicated code around whether statistics.module is enabled and working.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | uc_reports-numbering.patch | 490 bytes | Garrett Albright |
Comments
Comment #1
cha0s commentedsad panda will do this again and post up a patch
Comment #2
rszrama commentedQuick tip - don't try to take care of it all in one go. Let's actually make issues for individual changes and address as little as possible for the current branch. More issues, more precision, and planning for the future.
And please send panda my condolences. : (
Comment #3
cha0s commentedI have created a branch for this at http://66.93.231.252/branch/ubercart/2.x/uc_reports_refactor which contains the changes recommended here as commits. I also added a cleanup commit as the last revision to remove a couple instances of dead code.
Please check this ou with a visualization tool, as it will save a lot of time creating patches, since as you can see, the changes overlap. I could code all these at once, but I'd have to wait for each patch to be approved before I could create the next.
Comment #4
Island Usurper commentedExcept for the bug I found in the version of MySQL that I was using (which kept the tablesort from working for me), I say the product report looks a lot better.
Committed.
Comment #6
Garrett Albright commentedIf I may re-open this issue…
uc_reports.admin.inc line 245,
is inside an if clause:
and the end result is that the cells for that column are just 1, 1, 1, 1, etc if the Attributes module isn't enabled. Patch attached.
Though I wonder about the usefulness of just putting an increasing number in this column. Wouldn't something like the product SKU be more useful?
Comment #7
Island Usurper commentedA bit late, but I got around to committing it. Thanks, Garrett.