We have a product kit which contains a product which has attributes. When editing the product kit, the 'Adjustments' tab is displayed by the attributes module to let us change the SKU based on attribute.

However, my understanding is that product kits don't have a true SKU, just an amalgamation of their component SKUs. So it seems as though adjusting SKUs through this adjustments tab does not actually do anything. (?) I'm wondering if actually the adjustments tab should only display for products not product kits.

CommentFileSizeAuthor
#2 product_kit_attribute_tasks.patch405 bytesIsland Usurper

Comments

rszrama’s picture

rszrama commented
Assigned: Unassigned » Island Usurper

I think your assessment is spot on. I'm going to assign this to Lyle so he sees it tomorrow to throw in his 2 cents and review any patches that turn up.

Island Usurper’s picture

Island Usurper commented
Status: Active » Needs review
StatusFileSize
new product_kit_attribute_tasks.patch405 bytes

I guess since uc_attribute_form_alter() is already dealing with product kits as a special case, it should deal with them everywhere else, too. The nice thing about these menu item access callbacks is that I only had to change that one function.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks guys. We're applying that patch and will reopen if we find related issues.

Island Usurper’s picture

Island Usurper commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks for the review. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.