Strange "Do NOT auto-close final message" logic
Rob Loach - February 13, 2009 - 00:24
| Project: | Popups API (Ajax Dialogs) |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Having a checkbox with "Do NOT auto-close final message" in it creates some weird double negative logic. Not only that, having a default of enabled is also kind of weird. So, let's turn it into:
"Automatically close final confirmation messages"
| Attachment | Size |
|---|---|
| autoclose.patch | 8.44 KB |
#1
Good idea. I am going to go ahead and change the variable names to something sensible while I am at it (initially that was a message surpression flag, and I repurposed it without rename it. Bad Tao).
#2
This is now in dev and will be part of 1.2-alpha2.
#3
Automatically closed -- issue fixed for 2 weeks with no activity.