As per coding standards, we should use SELECT COUNT(*) instead of SELECT count(*) (SQL reserved words should be capitalized.

I see a few count() in SQL queries in:
modules/aggregator/aggregator.admin.inc (1)
modules/simpletest/tests/database_test.test (many here!)
and in:
modules/taxonomy/taxonomy.admin.inc (1).

CommentFileSizeAuthor
#6 373775.diff7.25 KBsoghad
#2 373775-database-test-inc.diff4.92 KBsoghad
#2 373775-taxonomy-admin-inc.diff1.28 KBsoghad
#1 373775.aggregator.admin_.inc_.patch980 bytessoghad

Comments

soghad’s picture

soghad commented
StatusFileSize
new 373775.aggregator.admin_.inc_.patch980 bytes

Fixed in aggregator.admin.inc

soghad’s picture

soghad commented
Status: Active » Needs review
StatusFileSize
new 373775-taxonomy-admin-inc.diff1.28 KB
new 373775-database-test-inc.diff4.92 KB

Fixed in:

/modules/simpletest/tests/database.test.inc

and

/modules/taxonomy/taxonomy.admin.inc

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: SELECT count(*) instead of SELECT COUNT(*) » SELECT COUNT(*) instead of SELECT count(*)

I was confused...your issue's title was backwards from what you were actually trying to accomplish.

recidive’s picture

recidive commented

@sog_hadgraft: try to put all your changes on a single patch, with paths relative to Drupal root directory, otherwise test bot won't be able to apply it.

Check Creating patches documentation for help.

soghad’s picture

soghad commented
Status: Needs work » Needs review
StatusFileSize
new 373775.diff7.25 KB

Thanks for the tip. In this latest post, I've included everything in one patch and created the diff relative to root.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

I did a quick grep and couldn't find any more. Looks good and the testbot likes.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.