Active Tags support

dragonwize - February 13, 2009 - 07:26
Project:Content Taxonomy
Version:6.x-1.x-dev
Component:Autocomplete - Freetagging
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

This patch is to provide an integration option with the Active Tags module. I've attached an screen shot of what the widget produces with this integration.

The code is dependent on #373602: Intergration support and load files when needed. So please do not commit until that patch is committed.

AttachmentSize
content_taxonomy-6--1-active_tags_support.patch1.93 KB
active_tags_widget.png1.95 KB

#1

Taras Zavaliy - February 21, 2009 - 21:17

Not working for me, sadly.
I've applied this patch for the latest Content Taxonomy dev build and dependent patch for the Active Tags module. Now I get a blank page (error) when trying to configure CT-autocomlete field with active tags widget anabled. The Active Tags module is working fine though. Anyone else to test this?

#2

dragonwize - February 21, 2009 - 21:35

Taras: Sorry, I forgot to attach the patch to my latest comment for the Active tags patch.

The patch is up now at http://drupal.org/node/373602#comment-1276502

Can you test again with that patch please.

#3

Taras Zavaliy - February 24, 2009 - 21:10

Well, now it's working, except for one thing :). The widget is using wrong vocabularies for the autocomplete.
I have 6 big vocabularies, and it suggests terms from all of them, but not from the one that is needed (and chosen in preferences for the autocomplete field). Can you fix the vocabulary load?

#4

dragonwize - February 24, 2009 - 21:31

@Taras: I believe that is a seperate issue with Active Tags currently. There is a patch available though. #321069: Active Tags only show me tags from another vocabulary

#5

Taras Zavaliy - February 26, 2009 - 21:24

@dragonwize - Thank's for the info, but that AT patch did not help me... I'll try to do some additional testing.

#6

shadysamir - March 12, 2009 - 11:19
Category:feature request» bug report

The patch works excepts it disables the autocomplete feature of the original widget.

I'm also getting "warning: Illegal offset type in isset or empty..." from both taxonomy.module and primary_term.module after saving content that uses the widget

#7

dragonwize - March 12, 2009 - 15:45
Category:bug report» feature request

shadysamir, please don't change the category. This is still a feature request not a bug report. If it is not working for you the status is the proper way to handle that by setting patch(code needs work).

Have you applied the active tags patch to the active tags module as well as this one to the content taxonomy module?

Another thing to check is to check and see if Active tags module works for you without the patches. If you still have trouble then it is Active tags not these integration patches.

The active tags module is working out some bugs in it's current version and there are several patches in it's queue that might fix you issues. But please use that issue queue to discuss those issues instead of here. Hopefully, the next AT version will be much more stable.

#8

shadysamir - March 12, 2009 - 18:07

Sorry about category change.

Active tags works fine without the patch and it has autocomplete. And I applied the patch and it all works great except for the lack of autocomplete and the error messages.

#9

dragonwize - March 12, 2009 - 18:11
Status:needs review» needs work

ok, I just became a co-maintainer to the Active tags module and will be posting a new version tonight. After I clean up some of the bugs there I will revisit this integration patch.

Thanks for testing.

#10

radj - March 13, 2009 - 03:01

Subscribing. Very important. Go go go! ^_^

#11

dragonwize - March 13, 2009 - 05:29

Ok, just cleaned up several issues with Active Tags and tested this patch again. It is still working well for me.

There is an issue still left standing with the active tags popular module that may be causing issues for some. #316401: SQL group by issues, pgSQL and MySQL 4

Also, I haven't fully tested this integration with all the nice limitation features of CT (deny any new terms, parent terms, depth, etc). So if you are using any of those options please let me know what configuration you are using so that I can make sure it works. I will do my own testing and mark this back to review with another patch when I am done.

#12

shadysamir - March 13, 2009 - 09:33

I do have the active tags popular module. I will try to remove it and see

Meanwhile, my options for the field are as follows:
Content_Taxonomy
Widget Type: Autocomplete (freetagging)
Allow and insert new terms
Extra parent: none
Use active tags style widget (check)
Number of values: unlimited
Saves vaues additionally to core taxonomy (check)
Vocabulary (my vocab selected)
Parent term: none

#13

shadysamir - March 13, 2009 - 10:01

I removed the active tags popular module and the problem persists. The active term widget itself as a taxonomy widget is still working properly with autocomplete

#14

dragonwize - March 13, 2009 - 12:29

shadysamir:

Are you using the new AT 1.2?

Hmm, are you saying that AT works for you by it self but not with CT?

What errors are you seeing? Can you post the exact error in full please?

#15

shadysamir - March 14, 2009 - 15:11

No I'm using AT 1.1. Just downloaded 1.2 and will test

Yes AT is working fine as a taxonomy widget with autocomplete, while with CT, autocomplete is not working.

#16

shadysamir - March 15, 2009 - 11:23

I installed AT 1.2 on a fresh drupal installation and installed CT and applied the patch. Autocomplete works now but the values are being populated from VID=10 not VID=11 as it's supposed to. I believe this is #321069: Active Tags only show me tags from another vocabulary issue, even thhough I noticed that in version 1.2 it was resolved:

My active_tags.js lines 71-72 have this:
function activetags_widget(context) {
var vid = context.substring(20,context.lastIndexOf('-'));

#17

dragonwize - March 15, 2009 - 22:36
Status:needs work» needs review

Fixed an important issue with Active Tags. My current testing is showing real promise.

Would love to get some testers feedback on using this patch with Active Tags 6.x-1.3.

#18

mh86 - March 16, 2009 - 17:39

I really like to add this feature to content taxonomy as soon as it is ready. so maybe some people have time to test the new version :)

#19

skizzo - April 28, 2009 - 09:08

I will be happy to test it. Just one question: is it ok to apply the patch
at http://drupal.org/node/373602#comment-1276502 to AT
6.x-1.4 ? I am currently running CT 6.x-1.x-dev built on 2009-04-07.

#20

dragonwize - April 28, 2009 - 12:55

No, no patch is need for AT any more. It has already been committed. All that you need do is apply this issue's patch to CT to test.

I might need to re-roll the patch after the march 16 updates. Let me know if it doesn't apply cleanly and I will post a re-rolled patch.

#21

skizzo - April 29, 2009 - 18:03

The patch applied cleanly. One thing I noticed on my installation is that the "Maximum number of values users can enter for this field" (from Global settings) is not enforced when entering CCK free tags. Is that the expected behaviour? Note that I am saving values also to the core taxonomy system.

#22

dragonwize - May 3, 2009 - 21:41

skizzo, I can not confirm that, it works fine for me. But if there is a bug with that, it is outside this issue of AT / CT integration and you should open a new issue with as much information as possible in it.

#23

skizzo - May 4, 2009 - 07:21

Thanks. Appended to http://drupal.org/node/342616

#24

giorgio79 - June 23, 2009 - 14:33

Hello dragonwize,

With the latest content taxonomy:

patch < content_taxonomy-6--1-active_tags_support.patch
(Stripping trailing CRs from patch.)
patching file content_taxonomy_autocomplete.module
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 86.
Hunk #3 FAILED at 196.
Hunk #4 FAILED at 416.
4 out of 4 hunks FAILED -- saving rejects to file content_taxonomy_autocomplete.module.rej

#25

dragonwize - June 27, 2009 - 14:14

Re-rolled.

AttachmentSize
content_taxonomy-6--1-active_tags_support.patch 1.93 KB

#26

shadysamir - July 1, 2009 - 13:28

Thank you, this works :)

#27

mh86 - July 15, 2009 - 11:35
Status:needs review» fixed

I committed patch from #25
Active Tags support is really cool, I'm going to add a note on the project page :-)
Thanks to dragonwize for the patch!

#28

System Message - July 29, 2009 - 11:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#29

Junro - October 10, 2009 - 10:20

Is this patch is committed in the dev. version ? Thanks

Right now, I'm using Active Tags module but sure, I will be better of using only Content Taxonomy module.

#30

dragonwize - October 10, 2009 - 14:38

This is in the latest dev and the lastest stable (1.0-rc2).

 
 

Drupal is a registered trademark of Dries Buytaert.