Postgresql 8.1 comes with build-in greatest() function. We create this function in database.pgsql, which brings errors.

The fix seems to be to add "" around the greatest, but I'll have to check it more before submitting a patch.

CommentFileSizeAuthor
#2 drupal-head-plpgsql_1.diff2.46 KBCvbge
#1 drupal-4-6-greatest-37383_0.diff897 bytesCvbge

Comments

Cvbge’s picture

Cvbge commented
Version: x.y.z » 4.6.3
Assigned: Unassigned »
Status: Active » Reviewed & tested by the community
StatusFileSize
new drupal-4-6-greatest-37383_0.diff897 bytes

Two people have reported that adding "" helps. I've checked that it works on postgresql 7.4
This patch is for 4.6, for 4.7 I want to drop dependency on plpgsql and this function will be done differently.

Cvbge’s picture

Cvbge commented
StatusFileSize
new drupal-head-plpgsql_1.diff2.46 KB

Here's a patch for cvs:
- adds a bit to CHANGELOG.txt
- supressess not-error messages in database.pgsql
- changes mysql-compatibility functions so they don't require plpgsql

After this patch gets in I'll write install.pgsql.txt for cvs, similar to 4.6

Cvbge’s picture

Cvbge commented

Hmm changelog.txt shouldn't probably talk about install.txt (since it's not yet fully written/committed), but that's not a big problem.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to DRUPAL-4-6 and HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)