Closed (fixed)
Project:
Chessboard Renderer
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
13 Feb 2009 at 10:53 UTC
Updated:
8 May 2010 at 16:30 UTC
Jump to comment: Most recent file
ran this through deadwood and so here it is
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | chessboard-port-373871-5.patch | 5.42 KB | eric_a |
| #10 | chessboard-port-373871-4.patch | 5.5 KB | eric_a |
| #9 | chessboard-port-373871-3.patch | 4.21 KB | eric_a |
| #2 | 373871-2.patch | 4.7 KB | eric_a |
| chessboard.tar_.gz | 114.72 KB | futuresoon |
Comments
Comment #1
eric_a commentedDeadwood has missed a few things. I'm going to submit a patch against HEAD in a couple of days. Including the stylesheet fix from branch DRUPAL-5 also needs to be in there. Future vision: it would be really nice if Chessboard Renderer would provide a chessboard render element builder. But first things first.
Comment #2
eric_a commentedThis patch brings HEAD to a Drupal 6 version of DRUPAL-5 except for the CCK stuff that is in DRUPAL-5 now but not in HEAD.
In effect this incorporates a couple of fixes in markup/css that have been committed to DRUPAL-5 after the last release.
Not incorporating the unreleased CCK stuff makes it easer to port to 6 and 7.
Comment #3
eric_a commentedComment #4
eric_a commentedI see now that development here has been done this way: Only sync changes to HEAD when you're going to start a new branch as described in http://drupal.org/handbook/cvs/branches-and-tags/contributions
Ok, I'm going to try make a patch that ports the current state of DRUPAL-5 instead of the current state of HEAD.
Comment #5
eric_a commentedBefore I post another patch here I'm proposing to revert the CCK features in DRUPAL-5. See #753848: Let Chessboard Renderer provide services to chess projects that provide game play and storage
Comment #6
eric_a commentedIf the CCK stuff is (temporarily) removed I will quickly submit patches for straight ports to 6 and 7.
(The field stuff can eventually be added back as a separate module to the different branches.)
Comment #7
eric_a commentedActually, there is probably no real need to do that CCK revert in DRUPAL-5.
The one thing I care about is to port this project quickly to Drupal 6 and 7 without the CCK stuff from the DRUPAL-5 branch for now.
If I submit a patch that brings HEAD to the Drupal 5 state I'm proposing, then that is the point to create a DRUPAL-6--1 branch from, right?
Or could you just bring HEAD to the exact current state of DRUPAL-5, create a DRUPAL-6--1 from there and have us submit patches?
What is needed to get us to Drupal 6 and 7?
Feedback would be much appreciated.
Comment #8
eric_a commentedThe patch is a straight (but untested) route to a working D6-state of the trunk, so please review.
It does contain slightly more than just an upgrade, because the DRUPAL-5 css fixes are in here as well.
Comment #9
eric_a commentedAfter a slight clean-up I now did a
cvs diff -upAnd I just realised that when applying this patch it does not handle the adding of the new chessboard.info file properly. I'll come back to this later.
Comment #10
eric_a commentedThis one is with the theme layer from #765582: Add theming layer to Chessboard Renderer.
Comment #11
eric_a commentedNope, it's this one.
Comment #12
eric_a commentedCommitted to CVS HEAD.