ran this through deadwood and so here it is

Comments

eric_a’s picture

Deadwood has missed a few things. I'm going to submit a patch against HEAD in a couple of days. Including the stylesheet fix from branch DRUPAL-5 also needs to be in there. Future vision: it would be really nice if Chessboard Renderer would provide a chessboard render element builder. But first things first.

eric_a’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new4.7 KB

This patch brings HEAD to a Drupal 6 version of DRUPAL-5 except for the CCK stuff that is in DRUPAL-5 now but not in HEAD.
In effect this incorporates a couple of fixes in markup/css that have been committed to DRUPAL-5 after the last release.
Not incorporating the unreleased CCK stuff makes it easer to port to 6 and 7.

eric_a’s picture

Version: 5.x-1.0 » 6.x-1.x-dev
Category: feature » task
eric_a’s picture

Status: Needs review » Needs work

I see now that development here has been done this way: Only sync changes to HEAD when you're going to start a new branch as described in http://drupal.org/handbook/cvs/branches-and-tags/contributions
Ok, I'm going to try make a patch that ports the current state of DRUPAL-5 instead of the current state of HEAD.

eric_a’s picture

Title: port to D6 » port Chessboard Renderer to D6

Before I post another patch here I'm proposing to revert the CCK features in DRUPAL-5. See #753848: Let Chessboard Renderer provide services to chess projects that provide game play and storage

eric_a’s picture

If the CCK stuff is (temporarily) removed I will quickly submit patches for straight ports to 6 and 7.

(The field stuff can eventually be added back as a separate module to the different branches.)

eric_a’s picture

Actually, there is probably no real need to do that CCK revert in DRUPAL-5.

The one thing I care about is to port this project quickly to Drupal 6 and 7 without the CCK stuff from the DRUPAL-5 branch for now.

If I submit a patch that brings HEAD to the Drupal 5 state I'm proposing, then that is the point to create a DRUPAL-6--1 branch from, right?

Or could you just bring HEAD to the exact current state of DRUPAL-5, create a DRUPAL-6--1 from there and have us submit patches?

What is needed to get us to Drupal 6 and 7?

Feedback would be much appreciated.

eric_a’s picture

Status: Needs work » Needs review

The patch is a straight (but untested) route to a working D6-state of the trunk, so please review.

It does contain slightly more than just an upgrade, because the DRUPAL-5 css fixes are in here as well.

eric_a’s picture

Status: Needs review » Needs work
StatusFileSize
new4.21 KB

After a slight clean-up I now did a cvs diff -up
And I just realised that when applying this patch it does not handle the adding of the new chessboard.info file properly. I'll come back to this later.

eric_a’s picture

Status: Needs work » Needs review
StatusFileSize
new5.5 KB

This one is with the theme layer from #765582: Add theming layer to Chessboard Renderer.

eric_a’s picture

StatusFileSize
new5.42 KB

Nope, it's this one.

eric_a’s picture

Assigned: Unassigned » eric_a
Status: Needs review » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.