Not having a form makes it hard to specify what message to display, yeah?

Check whether or not the filter form items have duplicate ids if more than one message is attached to a predicate...I'm not sure what'll happen....

CommentFileSizeAuthor
#2 ca_dsm_action.patch1.47 KBIsland Usurper
ca_dsm_action.patch1.52 KBIsland Usurper

Comments

cha0s’s picture

cha0s commented

I did this a while ago but perhaps Ryan changed his mind about including it now.

Island Usurper’s picture

Island Usurper commented
StatusFileSize
new ca_dsm_action.patch1.47 KB

I don't know anything about that.

Anyhow, the filter forms are being ditched, since we're trying to get it in for the beta4 today. We can look at it more closely later.

rszrama’s picture

rszrama commented
Status: Needs review » Needs work

Certainly didn't change my mind... but I don't know where the patch is atm. I reviewed this patch, but it failed on the input format. That's probably why I never finished it. Instead, I think we need to just only allow the default format for now until we can solve how to pass more appropriate data through to condition/action forms. This patch should be revised w/ a little description message added, and "Status" should be selected by default.

rszrama’s picture

rszrama commented
Issue tags: +CA
rszrama’s picture

rszrama commented
Status: Needs work » Needs review

fwiw, my comment above was supposed to be before Lyle's. : P

rszrama’s picture

rszrama commented
Status: Needs review » Reviewed & tested by the community

New patch tested out alright. Demo it on the Livetest by buying a large beanie. >:)

Island Usurper’s picture

Island Usurper commented
Status: Reviewed & tested by the community » Fixed

Yay, it works.

Status: Fixed » Closed (fixed)
Issue tags: -CA

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +CA

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.