The second two isset tests occur on creating an new vocabulary, or vocab term. I forget the use case to trigger the first notice, but could probably dig it up if you really need it.

Index: nodewords.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/nodewords/Attic/nodewords.module,v
retrieving revision 1.57.2.6
diff -r1.57.2.6 nodewords.module
137c137
<   if (isset($form['type']) && $form_id == $form['type']['#value'] .'_node_form') {
---
>   if (isset($form['type']) && isset($form['type']['#value']) &&  $form_id == $form['type']['#value'] .'_node_form') {
145c145
<     $id = $form['vid']['#value'];
---
>     $id = isset($form['vid']['#value']) ? $form['vid']['#value'] : '';
151c151
<     $id = $form['tid']['#value'];
---
>     $id = isset($form['tid']['#value']) ? $form['tid']['#value'] : '';
463a464,466
>       if (!array_key_exists($tag, $tags)) {
>         $tags[$tag] = NULL;
>       }

Thanks

Comments

Robrecht Jacques’s picture

Robrecht Jacques commented
Status: Active » Needs work

The first I had fixed already.
Fixed the two others.
Because of the non-unified diff, I have no clue as what the last one fixes. Could you use "diff -u"? See http://drupal.org/patch.

pletcher’s picture

pletcher commented

Uhg yeah, my bad, sorry. I keep forgetting that cvs diff checks the checked out version, not the latest branch version. The last one was an artifact from the previous patch I submitted, or was something I had patched and forgot to send upstream.

Index: nodewords.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/nodewords/Attic/nodewords.module,v
retrieving revision 1.57.2.20
diff -r1.57.2.20 nodewords.module
174c174
<     $id = $form['vid']['#value'];
---
>     $id = isset($form['vid']['#value']) ? $form['vid']['#value'] : '';
180c180
<     $id = $form['tid']['#value'];
---
>     $id = isset($form['tid']['#value']) ? $form['tid']['#value'] : '';

That will remove the notices on the creation of vocabs and terms.

Sorry about that,
jrp

pletcher’s picture

pletcher commented
Status: Needs work » Fixed

Man, its late and I'm striking out. Just re-read your last comment.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.