Closed (fixed)
Project:
Node Comments
Version:
6.x-1.2-rc2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Feb 2009 at 07:13 UTC
Updated:
7 Apr 2009 at 21:50 UTC
The 'sample' node-comment.tpl.php file and nodecomment.module file both make use of the Drupal 5.x style "l" function which takes up to 7 arguments and not the Drupal 6.x style which takes only 3. This causes data other than an array to be passed into "l," giving me the following PHP error and preventing my content from being themed.
[14-Feb-2009 01:42:53] PHP Fatal error: Unsupported operand types in /home/njds/public_html/includes/common.inc on line 1546
That line in common.inc is within the definition of the "l" function:
$options += array(
'attributes' => array(),
'html' => FALSE,
);
This is from the += operator getting a non-array value, I think.
I have attached a patch which needs review, but seems to have eliminated the problem for me.
| Comment | File | Size | Author |
|---|---|---|---|
| nodecomment-fix-l.patch | 2.26 KB | msielski |
Comments
Comment #1
msielskiBump on this... I am fielding people in #drupal-support asking why node comment is not displaying their comments.
Comment #2
psynaptic commentedPatch is good. Please commit!
Comment #3
henrijs.seso commentedworks.
Comment #4
zroger commentedcommitted: http://drupal.org/cvs?commit=187996