Patch checks if the field is empty before foreach().

CommentFileSizeAuthor
#1 filefield_field.inc_.patch497 bytesq0rban
filefield_php_notice_node_update.patch859 bytesamitaibu

Comments

q0rban’s picture

q0rban commented
Title: PHP notice on node update » foreach errors on update
StatusFileSize
new filefield_field.inc_.patch497 bytes

So, to explain this a bit further, basically filefield looks for deleted files on a node that didn't have any files to begin with. So you get errors on the foreach on line 124 since $orig->$field['field_name'] is not an array.

q0rban’s picture

q0rban commented
Title: foreach errors on update » foreach errors after editing a node with no files
dopry’s picture

dopry commented
Status: Needs review » Reviewed & tested by the community
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

I think that the if !empty is more standard then casting to (array).

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Fixed in #369310: Invalid argument supplied for foreach() when updating nodes.