Closed (fixed)
Project:
Project issue tracking
Version:
6.x-1.x-dev
Component:
Issues
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Feb 2009 at 21:07 UTC
Updated:
28 Aug 2009 at 04:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
nancydruBTW I would be happy with using check_markup and letting it use DEFAULT_FILTER_FORMAT.
Comment #2
michelleI'd like this, too. A solid wall of text is hard to read and even more likely to be ignored.
Michelle
Comment #3
gregglesI've been annoyed by this before as well. Currently it is filtered by "filter_xss" without a second argument which removes xss, but also removes any tags that are "block" elements (i.e. p, br, etc.).
The only drawback I know of switching from filter_xss to check_markup is that check_markup by default adds a p tag around the block of text which can add more whitespace than necessary in some circumstances.
Comment #4
nancydruThanks, Greggles. In this case, I would rather have more whitespace than a solid block of text. But if it is objectionable, then perhaps filter_xss_admin would work.
Since I want to see this on DO, how can it be reviewed and tested? The code looks fine to me.
Comment #5
gregglesSince this setting can be edited by a large number of users who may not be totally trustworthy I don't feel that filter_xss_admin is appropriate.
In terms of how to get it reviewed and tested...install project and project_issue and test it.
Comment #6
dwwGood idea. Tested and it works fine. Only change is that we should do the same for the site-wide help text (which appears just above in the form). Committed that to both HEAD and DRUPAL-5--2.
Now this just need to be deployed on d.o. Luckily, we've got downtime in 2 hours. ;)
Comment #7
nancydruFabulous, thanks to both of you. And downtime means a chance for a quick nap...
Comment #8
dwwDeployed.
Comment #9
nancydruAnd being used successfully.