hi rjerome,
A warning
When I submit a biblio node and give some keywords,it is ok. But when I edit it,there is a warning,like this warning: Invalid argument supplied for foreach() in .../modules/biblio/biblio.module on line 963.
If when I submit it ,empty the keywords line , there is not warning.I check this line code ,it doesn't like old version.Comaprison 959-969 lines in biblio.module with rc5v and the old,it looks different.
RC5 version:

        if ($key == 'biblio_keywords' ) {
          $sep = variable_get('biblio_keyword_sep', ',');
          $keywords = '';
          if (!empty($node->$key)) {
            foreach ($node->$key as $keyword) {
              $keywords .= (empty($keywords)?$keyword->word:"$sep " . $keyword->word);
            }
          }
          $node->$key = $keywords;
          $fld['hint'] = t('Separate keywords using the " @sep " character', array('@sep' => $sep));
        } 

Old version:

        if ($key == 'biblio_keywords' ) {
          $sep = variable_get('biblio_keyword_sep', ',');
          if (!empty($node->$key)) {
            foreach ($node->$key as $keyword) {
              $keywords .= (empty($keywords)?$keyword->word:"$sep " . $keyword->word);
            }
          $node->$key = $keywords;
          }

          $fld['hint'] = t('Separate keywords using the " @sep " character', array('@sep' => $sep));
        } 

Could you tell me where is wrong?

A fix
On mysite/biblio/authors page,when you click the edit link behind every author, Url is not correct.It looks like "mysite/1/edit",but right url is "mysite/biblio/author/1/edit".So 1011 line in biblio.pages.inc of RC5, return l(' ['.t('edit').']', "$path" . $author['cid'] ."/edit/" ); should be return l(' ['.t('edit').']', "$path/author/" . $author['cid'] ."/edit/" );

Comments

rjerome’s picture

You wouldn't happen to have multiple versions of the module in different directories under your Drupal tree would you?

Both of the issues you mention have been fixed in RC5.

xtian_chin’s picture

No such things you worried.
When I edit a biblio node which keywords field I filled,there is nothing in the keywords field and report warning I mentioned up.

rjerome’s picture

Have you tried the -dev version?

xtian_chin’s picture

Version: 6.x-1.0-rc5 » 6.x-1.0

I am waiting for the stable version and now I update to 6.x-1.0.Thanks your work,rjerome.
But the warning still.
warning: Invalid argument supplied for foreach() in .../sites/all/modules/biblio/biblio.module on line 998.
When I submit a biblio node and give some keywords,it is ok. But when I edit it,there is a warning,and When I edit a biblio node which keywords field I filled,there is nothing in the keywords field and report warning I mentioned up.

Do I need to uninstall biblio module and reinstall it?

rjerome’s picture

If you could uninstall and reinstall that would help eliminate on potential cause of this problem.

Also, could you tell me which version of PHP you are running?

Could you also tell what revision number and date you see on the "admin/settings/biblio" page, just above the "Base URL" text box.

xtian_chin’s picture

php version :5.2.6
Revision: 1.9.2.50 Date: 2009/03/06 03:12:57

liam morland’s picture

Status: Active » Closed (outdated)

This version is no longer maintained. If this issue is still relevant to the Drupal 7 version, please re-open and provide details.