I just upgraded the RealName Module from 6.x-1.1 (2009-Jan-01) to 6.x-1.x-dev (2009-Feb-12). I am using the Core Profile module as field provider. In 1.1, the title of a user's "My account" page was her real name, as expected. In the new dev version, the title now reads "My account" literally. What change happened to the code that broke the original behavior?

CommentFileSizeAuthor
#1 375692.patch834 bytesroball

Comments

roball’s picture

roball commented
Status: Active » Needs review
StatusFileSize
new 375692.patch834 bytes

The attached patch solved the problem for me :-)

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

In fixing the title (and bypass a core bug) on the user page, I decided to be more like core. I think this is more appropriate and makes the breadcrumbs correct. Unless you can provide a more compelling argument, I will leave it like this.

roball’s picture

roball commented

Without your module enabled, Drupal itself would not print "My account" literally, but the username instead. With your module enabled, I would expect to have the username replaced by the realname. I don't see an advantage in changing this to the same fixed wording for all users.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Assigned: Unassigned » nancydru
Status: Needs review » Fixed

Hmm, I wonder where I picked up that bit of code from - I could have sworn it was the User module. But then again, the user module has a problem with the menu code...

Anyway, I kind of like "My account" because it tells my users how they got there. So I made it a default option; you can go back to the way you like by unchecking it on the settings page.

roball’s picture

roball commented
Status: Fixed » Active

Thank you Nancy for adding this as an option. However, with realname.module v1.4.4.34 now either the wording "My account" or the realname (depending on the new setting on or off) will be displayed on *every* page!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I only see it on "/user/..." pages.

roball’s picture

roball commented

Just checked it again - I really have it on each and every page.

bobgeier’s picture

bobgeier commented
Status: Active » Fixed

I can confirm roball's bug as well, but for clarity have moved it to a new issue. See http://drupal.org/node/378938

This issue is now fixed.

roball’s picture

roball commented
Status: Fixed » Closed (fixed)