Closed (fixed)
Project:
Ubercart
Version:
6.x-2.0-beta4
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
17 Feb 2009 at 19:31 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent
This patch is limited in scope to simply address the throbber on the checkout form for the payments pane. Whereas the throbber was added purely by JS, it is now working through a CSS class as it should be. The styles have been placed in uc_store.css. It's using a relative path of /misc/throbber.gif to display the throbber, so please post up if this causes any issues. It worked on the 2.x Livetest which sits in a subdirectory.
| Comment | File | Size | Author |
|---|---|---|---|
| payment_pane_line_item_throbber.patch | 1.05 KB | rszrama |
Comments
Comment #1
cha0s commentedGood concept, but just /misc/throbber.gif doesn't cut it. For instance, on my server, webroot is /var/www, but Drupal (6) is installed at /var/www/cha0s/dev/ubercart/2, so it'd have to be /cha0s/dev/ubercart/2/misc/throbber.gif for me. I'm not sure of any way to change that URL at run-time ('cept JS) but maybe we should look into if that's possible.
Comment #2
rszrama commentedWell, the relative URL there has nothing to do with the system path. I'm also not sure how it plays with sites in subdirectories. I assumed this would not work on the 2.x Livetest because it's in the uc2 subdirectory, but by all appearances it still works. Did you patch this into your install and it didn't show the throbber? Can you see it on the 2.x Livetest, or am I just crazy? : D
Comment #3
cha0s commentedI'll take a look tomorrow at the apache configuration for livetest. / goes from the webroot, whereas basepath is the correct path. I'm not trying to be picky, this simply isn't a reliable fix.
Comment #4
rszrama commentedI agree... that's why I don't understand why it's workin' on the Livetest. I am still looking to see if it's actually tested as broken in other subdirectory settings, so please post up if it's not working on your demo site. I'm going to do it on a local site which is in a subdirectory at localhost/uc2test as well.
fwiw, core uses the throbber w/ a relative path from the system module directory. We could always try to use the same style... we just have to duplicate the #ahah framework's HTML (including its classes). That wouldn't be bad, since technically all this stuff is AHAH anyways, it's just that that HTML could be disruptive... unless we simply kept our stuff the way it is and made a simple JS utility function that inserted the HTML like misc/ahah.js does.
Comment #5
rszrama commentedJust a confirmation. The relative path didn't work on a local test. Weirdness.
I think I favor mimicking core on this if possible.
Comment #6
rszrama commentedErm... so, I'm a goober. What if we just add throbber.gif to the images subdirectory in uc_store and make this style set the background to url(images/throbber.gif)? Seems to work for me...
Comment #7
rszrama commentedTested and confirmed. This is the simplest way to go. Would post an updated patch if attachments were working on issues...