Download & Extend

Do not display favicon in links with images

Project:URL Icon
Version:6.x-2.1
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

When a link is an image it looks really strange with both icons.

This patch changes the filter, so it does not add favicons when an Only local images are allowed.

AttachmentSize
urlicon-notifhasimg.patch1.33 KB

Comments

#1

Status:needs review» needs work

+++ urlicon-patched/urlicon.module 2009-02-17 22:10:40.000000000 +0100
@@ -87,6 +87,9 @@
+  # skip if this link is around an image
+  if (stripos($match[3], '<img ') !== false) return $match[0];

Please take a look at the Drupal coding standards. Comments should be // Comment. and the if clause should always use {} and line breaks. And maybe wrap this into a funtion so there is less copy & paste code.

Otherwise I think this is a good idea but maybe should get a switch for activation so the user can decide to use this.

Powered by Dreditor.

nobody click here