Right and Left are incorrect, because in RTL languages the sidebars should change sides. I've renamed them to primary and secondary.

Comments

amitaibu’s picture

Issue tags: +RTL

Add 'RTL' tag.

amitaibu’s picture

StatusFileSize
new10.41 KB

Forgot the zen.info file.

amitaibu’s picture

johnalbin’s picture

Interestingly, Layout Studio uses Secondary and Tertiary as the names of the sidebars. Presumably, this is because the main content is the "primary" source of content. :-\

I'm glad you left the variables as $left and $right since Drupal treats those variable names specially.

Amitai, I apologize for not getting to these RTL issues sooner! Things have been crazy busy for me. But I want these RTL issues to be one of the first things I get to for Zen 6.x-2.x.

amitaibu’s picture

>> Amitai, I apologize for not getting to these RTL issues sooner!
No problem, if you need me, I'm still around :)

johnalbin’s picture

Component: Code » CSS/HTML Markup
StatusFileSize
new14.99 KB

Here's an updated patch that fixes a couple of minor things.

johnalbin’s picture

StatusFileSize
new14.99 KB

Trying to attach the patch again.

johnalbin’s picture

Title: Change sidebars name to be RTL friendly » Change sidebar names to be RTL friendly
Status: Needs review » Fixed

Ok. I've committed this patch.

However, I'm going to be tracking the Drupal 7 issue for #226587: Default sidebar region labels are confusing (wrong) for RTL languages and if that issue decides to use a different naming scheme for D7's sidebars, I'll use those names.

Thanks, Amitai!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

johnalbin’s picture

Status: Closed (fixed) » Active

Given the recent discussion in #226587: Default sidebar region labels are confusing (wrong) for RTL languages, I'm going to change the sidebar names from primary/secondary to first/second.

johnalbin’s picture

Status: Active » Fixed

Ok, the changes have been committed. I hope I got everything.

Status: Fixed » Closed (fixed)
Issue tags: -RTL

Automatically closed -- issue fixed for 2 weeks with no activity.