Posted by Amitaibu on February 17, 2009 at 10:21pm
3 followers
| Project: | Zen |
| Version: | 6.x-2.x-dev |
| Component: | CSS/HTML Markup |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Amitaibu |
| Status: | closed (fixed) |
| Issue tags: | RTL |
Issue Summary
Right and Left are incorrect, because in RTL languages the sidebars should change sides. I've renamed them to primary and secondary.
| Attachment | Size |
|---|---|
| rename_sidebar_to_be_rtl.patch | 9.77 KB |
Comments
#1
Add 'RTL' tag.
#2
Forgot the zen.info file.
#3
btw, depends on #283978: RTL support for IE stylesheets
#4
Interestingly, Layout Studio uses Secondary and Tertiary as the names of the sidebars. Presumably, this is because the main content is the "primary" source of content. :-\
I'm glad you left the variables as $left and $right since Drupal treats those variable names specially.
Amitai, I apologize for not getting to these RTL issues sooner! Things have been crazy busy for me. But I want these RTL issues to be one of the first things I get to for Zen 6.x-2.x.
#5
>> Amitai, I apologize for not getting to these RTL issues sooner!
No problem, if you need me, I'm still around :)
#6
Here's an updated patch that fixes a couple of minor things.
#7
Trying to attach the patch again.
#8
Ok. I've committed this patch.
However, I'm going to be tracking the Drupal 7 issue for #226587: Default sidebar region labels are confusing (wrong) for RTL languages and if that issue decides to use a different naming scheme for D7's sidebars, I'll use those names.
Thanks, Amitai!
#9
Automatically closed -- issue fixed for 2 weeks with no activity.
#10
Given the recent discussion in #226587: Default sidebar region labels are confusing (wrong) for RTL languages, I'm going to change the sidebar names from primary/secondary to first/second.
#11
Ok, the changes have been committed. I hope I got everything.
#12
Automatically closed -- issue fixed for 2 weeks with no activity.