Closed (works as designed)
Project:
Blockquote
Version:
6.x-1.0
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
18 Feb 2009 at 04:15 UTC
Updated:
22 Feb 2009 at 03:35 UTC
Using Drupal 6.9 with the Garland theme. If you create a Page with BLOCKQUOTE commands in it and save the page with the type HTML the block shows up correctly with the upper left and lower right delimiters and in italics and indented. Saving the same page as type PHP removes the graphic delimiters but maintains the text in italics and indented. If the material in the BLOCKQUOTE tags contains multiple paragraphs delimited by multiple BR tags the paragraph spacing also changes with the HTML/PHP page types. One would expect the page to show up the same if saved as HTML or PHP type.
Thank you for the otherwise very nice module. It's quite nice.
Comments
Comment #1
FILExt commentedJust to add: I was using PHP because it did not automatically convert URLs to links but found the filter to turn that behavior off (I'm rather new at this) and have now converted the PHP pages back to Full HTML and the images appear. The paragraph formatting is still off however when there are multiple paragraphs in a single quote so I believe there is still a bug somewhere in the module; multiple bugs if you consider the PHP/HTML change improper behavior. Hope that helps some.
Comment #2
zeta ζ commentedHi FILExt,
I’m afraid it’s been a while since I last looked at this – may I summarise?…
What has changed? Can you provide an example (link), and describe what you expect?
Can you use <p>…</p> tags for paragraphs instead of <br /><br />? eg a poem could be formatted thus;-
Comment #3
FILExt commentedSorry for the confusion. The summary should be: Worked OK in Full HTML, didn't put in the graphics in PHP, and with multiple paragraphs the paragraph separation does not work in either.
I'm building a new cknow.com site and have the access turned off for other users but have turned it on for this so a sample page showing this would be: http://file-extension-data.com/oldnewsletters/1997-09.html
Neither the "p" nor the "br" tags work to put some space between paragraphs. I even used "p" tags followed by "br" tags in the same document and still no space. You can look at the source for the above page and see that the paragraph pages are in there (including a blank paragraph tag between each paragraph) but it still doesn't add spaces. Using Firebug I can't seem to see where the CSS should be changed to allow this.
Thanks.
Comment #4
zeta ζ commentedThe module has a file called blockquote-neutralise.css – the intention is to limit the effect of Blockquote if you are using a theme other than Garland. What do the quotes look like without the Blockqote module?
Your theme should control the paragraph formatting, though I might be able to add an administrative option to allow Blockquote to control paragraph formatting.
In the meantime, you could try commenting out the contents of blockquote-neutralise.css .
Comment #5
FILExt commentedThank you. Commenting out blockquote-neutralise.css seems to fix the problem and allows spaces between paragraphs. I did not try it using the PHP save type.
If I disable the module, the surrounding graphics go away (of course), the italics disappear, but the text is formatted properly with an indent but no italics.
While I'm not using Garland, I am using a theme of my own that is Garland with only the name changed (and those files specific to Garland changed accordingly). I did this so I could evaluate any Garland changes in Drupal updates and apply them selectively as necessary. Did not want any theme changes to sneak up on me. Eventually, I may change some small features of the theme but that's a project for after the content gets updated and everything put on the real domain.
I'll leave the neutralise fix in for now and press on. Appreciate the help.
Comment #6
FILExt commentedOh yes, for others, I've put the site back into maintenance mode so outsiders and spiders can't see it now that this matter is at least fixed for me. So, the link above won't produce a page any longer.