I have found some issues with blocks. As it could be interesting, I am working with a Zen sub-theme.

> The Block defined by default when using subscription is showed in the block list with the description name wrongly integrated showing a xxx .
PayPal Subscription: XXXXXXXXXXXXXXXXXXX

> When showing this block in some region, if you don't put a title (using ) then the subscription description title goes as an h1 header to the main content section, but it you put a title then the block title is the one you have choosen and there is no subscription description wrong in the main content area.

> The paypal icon is not shown

Comments

jcmarco’s picture

jcmarco commented

Just a clarification:

Second point regarding the subscription description issue, it always come up as in the main content section, as h1, independently of the block title.

lyricnz’s picture

lyricnz commented

6.x-2.x-dev is an experimental / development branch. You shouldn't be using it, unless you want to help us develop the next generation of LM Paypal :) The code you're using is probably quite old (when did you get the -dev release?). If you want to help us, please checkout the DRUPAL-6--2 branch from CVS.

jcmarco’s picture

jcmarco commented

I got the code yesterday. And of course I am testing it in a devel server.
I already knew the 5.x-1.x and I am migrating to 6.x so after testing 6.x-1.x-dev
I decided to take a look at this new version just to know if it was worthy or not waiting this new release.
Of course it looks cleaner and best organized than version 1.x.

Other bug, by the way is when selecting a value for donation:
lm_paypal_donate(array(5), 'USD', 'donation to example.com') and
lm_paypal_donate(array(5,array(10),15,), 'USD', 'donation to example.com', '', 'Donation')
In the first case there is no way to entry any value and in second option the is not default value.

lyricnz’s picture

lyricnz commented

Patch please!

pounard’s picture

pounard
Primary language French
commented

I may have done some dirty code on donations and subscription, and broke the API. The old code, was just, awful! I did a lot of refactor, but some parts miss SimpleTest. You have to understand that, right now, we are breaking all the old code. We are going to need your help testing it, when we'll release and alpha version. Right now, this is really unstable code!

What you are experiencing could be be an API refactor :)
I'll take a look when I'll have time to spare (no promises here, I'm really full & busy at work).

Ah, and for the icon, it's normal, the lm_paypal module now provide a generic paypal form. This form has the (dis)avantage of not providing a nice image button but a default form submit button. I'm currently trying to find a non-dirty and clean solution to display an image button instead of the awful default submit button.

I have to look over the form API to do this, please be more patient for some weeks.

Really thanks for submitting this, I'll look further when I'll have time to.

I wish it looks better organized than other version! 1.x is really a mess, PHP3 style code, really old, unsecure, and full of bugs. Also newer is really more efficient.

EDIT: typo errors and better explainations (again).

lyricnz’s picture

lyricnz commented

I have just fixed the default value on the selection
lm_paypal_donate(array(5,array(10),15,), 'USD', 'donation to example.com', '', 'Donation')

Most other bugs remain - I could really use some more help!

pounard’s picture

pounard
Primary language French
commented

I'm still really really busy at work. I'll try to spend some hours on lm_paypal as soon as I have a real break. Maybe next month, maybe not.

lyricnz’s picture

lyricnz commented

From the original issue:

- The Block defined by default when using subscription is showed in the block list with the description name wrongly integrated showing a xxx . PayPal Subscription: XXXXXXXXXXXXXXXXXXX

I believe this is fixed now?

- When showing this block in some region, if you don't put a title (using ) then the subscription description title goes as an h1 header to the main content section, but it you put a title then the block title is the one you have choosen and there is no subscription description wrong in the main content area.

I can confirm that putting the block on the page breaks the Drupal page title. This is because lm_paypal_subscriptions_block() calls lm_paypal_subscribe_subscription() to get the output text, and that calls lm_paypal_subscriptions_details() which calls drupal_set_title(). A really bad idea!

- The paypal icon is not shown

Confirmed - this doesn't seem to be shown anywhere, anymore. I think this is due to the refactoring of the form-generation, which has broken a few things :/

From comment #3 above:

- lm_paypal_donate(array(5), 'USD', 'donation to example.com') and
lm_paypal_donate(array(5,array(10),15,), 'USD', 'donation to example.com', '', 'Donation')
In the first case there is no way to entry any value and in second option the is not default value.

Yes, same reason as above - the refactoring doesn't support the textfield yet. I've fixed the second issue