Remove dependence on uc_catalog_name variable [#376277]

So, looking through the catalog module, I see in various instances:

variable_get('uc_catalog_name', t('Catalog'));

The problem is, as best as I could tell, there's no way to actually change that variable. It gets set in the install file using $t() and is never touched again. This leads me to believe it's pointless and just gets in the way of translation. : )

I say that because it throws a marker error on rak's translation server. I'm guessing the variable was used originally to let people change the title of their catalog... then we realized that wasn't multi-lingual safe, took out the setting, but never cleaned up the variable's usage. As far as I can tell, the fix is to just convert all instances of that variable_get() to just be t('Catalog').

Any reason not to?

Comment	File	Size	Author
#6	376277-remove-uc_catalog_name.patch	4.92 KB	longwave

Comments

Comment #1

Island Usurper commented 23 February 2009 at 19:01

It may possibly depend on context. Sometimes, the word "Catalog" is referring to the vocabulary name, and in those places, that's what is supposed to be used. I believe it was meant to keep the module from having to load the vocabulary from the database when all it really needed was the name. This probably got changed at some point but the code wasn't ever removed.

Comment #2

Island Usurper commented 23 February 2009 at 19:51

Status:

Active

» Postponed (maintainer needs more info)

It's set in uc_catalog_taxonomy() whenever the catalog vocabulary is updated. I don't know how easily you can translate vocabularies, so I'm not so sure about how to fix it.